DATE type initial support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also, extend init_diagnostic() to reset all diagnostic fields.
- replace the 'SELECT 0' connection testing with a better test: ES/SQL data types loading. This also better fits with do_connect() function fully preparing the connection for usage.
If using a running staged instance skip the (in this case) unnecessary version parameter validation.
- fix allocation size of server version string; - fix column parameter logging.
- the type is now understood by the driver (no data conversion supported yet)
Closed
droberts195
approved these changes
Jan 28, 2019
bpintea
added a commit
that referenced
this pull request
Jan 29, 2019
* add a diagnostics resetting macro - also, extend init_diagnostic() to reset all diagnostic fields. * replace simple conn test with SQL data type load - replace the 'SELECT 0' connection testing with a better test: ES/SQL data types loading. This also better fits with do_connect() function fully preparing the connection for usage. * fix: don't require ES version if using staged inst If using a running staged instance skip the (in this case) unnecessary version parameter validation. * fix: correct alloc size and logged struct field - fix allocation size of server version string; - fix column parameter logging. * add DATE data type initial support - the type is now understood by the driver (no data conversion supported yet) * add DATE initial support into u-testing framework (cherry picked from commit 90c79bf)
bpintea
added
>feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the new DATE ES/SQL (runtime-only) data type (elastic/elasticsearch#37693): the date type will be accepted by the driver and passed onto the application, but no data conversions are possible yet (should applications request them).
The PR also changes the connection testing: the "simple" query has been replaced by data type loading. This improves the testing by setting up the connection just like before "normal" operation would. (Specifically, data types misalignment would no longer be possible, when connection testing would work, but application connecting would later fail.)
A couple of fixes are also addressed: