Close cursor #102
Merged
Close cursor #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit the driver will close a cursor received from ES/SQL when the statement is closed (i.e. IRD cleared). This should release faster any resources running against a timer in ES. An integration test had been added for it as well. The integration tests "framework" got a new CLI paramter, to force data-reindexing. Also, the "ephemeral" paramter nwo controls the driver uninstallation too. The advertised driver capabilities are also updated to reflect the progress on ES/SQL side.
droberts195
approved these changes
Jan 29, 2019
bpintea
added a commit
that referenced
this pull request
Jan 29, 2019
* cursor closing on statement closing With this commit the driver will close a cursor received from ES/SQL when the statement is closed (i.e. IRD cleared). This should release faster any resources running against a timer in ES. An integration test had been added for it as well. The integration tests "framework" got a new CLI paramter, to force data-reindexing. Also, the "ephemeral" paramter nwo controls the driver uninstallation too. The advertised driver capabilities are also updated to reflect the progress on ES/SQL side. * remove stale comment * fix typo in help string (cherry picked from commit af31b05)
Merged
Closed
bpintea
added
>feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the driver will close a cursor received from ES/SQL
when the statement is closed (i.e. IRD cleared). This should release
faster any resources running against a timer in ES.
An integration test had been added for it as well.
The integration tests "framework" got a new CLI paramter, to force
data-reindexing. Also, the "ephemeral" paramter nwo controls the driver
uninstallation too.
The advertised driver capabilities are also updated to reflect the
progress on ES/SQL side.