Init all record fields #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the string record fields have been left 0-ed, which is problematic when their value is asked for. This commit inits them all to the empty string, so that the transfer can take place. (Their value would normally be provided by the data source, but this is now not available with the current ES/SQL API.)
bpintea
added a commit
that referenced
this pull request
Feb 11, 2019
Some of the string record fields have been left 0-ed, which is problematic when their value is asked for. This commit inits them all to the empty string, so that the transfer can take place. (Their value would normally be provided by the data source, but this is now not available with the current ES/SQL API.) (cherry picked from commit f50959b)
bpintea
added a commit
that referenced
this pull request
Feb 11, 2019
Some of the string record fields have been left 0-ed, which is problematic when their value is asked for. This commit inits them all to the empty string, so that the transfer can take place. (Their value would normally be provided by the data source, but this is now not available with the current ES/SQL API.) (cherry picked from commit f50959b)
bpintea
added a commit
that referenced
this pull request
Feb 11, 2019
Some of the string record fields have been left 0-ed, which is problematic when their value is asked for. This commit inits them all to the empty string, so that the transfer can take place. (Their value would normally be provided by the data source, but this is now not available with the current ES/SQL API.) (cherry picked from commit f50959b)
bpintea
added a commit
that referenced
this pull request
Feb 11, 2019
Some of the string record fields have been left 0-ed, which is problematic when their value is asked for. This commit inits them all to the empty string, so that the transfer can take place. (Their value would normally be provided by the data source, but this is now not available with the current ES/SQL API.) (cherry picked from commit f50959b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the string record fields have been left 0-ed, which is
problematic when their value is asked for. This PR inits them all to
the empty string, so that the transfer can take place.
(Their value would normally be provided by the data source, but this is
now not available with the current ES/SQL API.)
The PR also fixes two API tracing statements.