Fix: string and floats conversion fixes #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of SQLWCHAR to SQLCHAR conversion the truncation indication was wrongly signaled (the conversion was performed correctly, though). This happened because of the wrong number of bytes compared against available buffer: the SQLWCHAR string space instead of the (correct) converted equivalent.
- double zero will be less than FLT_MIN and still a valid float; - double zero to integers conversions consider this case already and are not affected.
bpintea
added a commit
that referenced
this pull request
Feb 26, 2019
* fix wide to C string conversion truncation indic. In case of SQLWCHAR to SQLCHAR conversion the truncation indication was wrongly signaled (the conversion was performed correctly, though). This happened because of the wrong number of bytes compared against available buffer: the SQLWCHAR string space instead of the (correct) converted equivalent. * added unit test for the fix * fix: consider val 0 on dbl to float range check - double zero will be less than FLT_MIN and still a valid float; - double zero to integers conversions consider this case already and are not affected. (cherry picked from commit f6669dd)
bpintea
added a commit
that referenced
this pull request
Feb 26, 2019
* fix wide to C string conversion truncation indic. In case of SQLWCHAR to SQLCHAR conversion the truncation indication was wrongly signaled (the conversion was performed correctly, though). This happened because of the wrong number of bytes compared against available buffer: the SQLWCHAR string space instead of the (correct) converted equivalent. * added unit test for the fix * fix: consider val 0 on dbl to float range check - double zero will be less than FLT_MIN and still a valid float; - double zero to integers conversions consider this case already and are not affected. (cherry picked from commit f6669dd)
bpintea
added a commit
that referenced
this pull request
Feb 26, 2019
* fix wide to C string conversion truncation indic. In case of SQLWCHAR to SQLCHAR conversion the truncation indication was wrongly signaled (the conversion was performed correctly, though). This happened because of the wrong number of bytes compared against available buffer: the SQLWCHAR string space instead of the (correct) converted equivalent. * added unit test for the fix * fix: consider val 0 on dbl to float range check - double zero will be less than FLT_MIN and still a valid float; - double zero to integers conversions consider this case already and are not affected. (cherry picked from commit f6669dd)
bpintea
added a commit
that referenced
this pull request
Feb 26, 2019
* fix wide to C string conversion truncation indic. In case of SQLWCHAR to SQLCHAR conversion the truncation indication was wrongly signaled (the conversion was performed correctly, though). This happened because of the wrong number of bytes compared against available buffer: the SQLWCHAR string space instead of the (correct) converted equivalent. * added unit test for the fix * fix: consider val 0 on dbl to float range check - double zero will be less than FLT_MIN and still a valid float; - double zero to integers conversions consider this case already and are not affected. (cherry picked from commit f6669dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two conversion fixes:
0 < FLT_MINlead to an error; the range check is required since the double resolution is higher than float's and naturally not all doubles can be converted losslessly to floats; in this check zero is a special case).