Add dependencies as subtrees #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: libs/ODBC-Specification git-subtree-split: 51d4b3a197a9333a7c8a7685c17c462df5e29cc7
git-subtree-dir: libs/c-timestamp git-subtree-split: b205c407ae6680d23d74359ac00444b80989792f
git-subtree-dir: libs/ujson4c git-subtree-split: 65d3e35864ee501a2b21fe5af8a45667d36a42be
git-subtree-dir: libs/curl git-subtree-split: d0924d0e03ef6ecc8da27d57f2f4994bcfb7af29
- this should simplify building and maintaining the project; - libcurl is build at config stage now, as a prerequisite; (this will also skip attempting to build it along with the driver.)
6c0831944 add function to return lenght of an array git-subtree-dir: libs/ujson4c git-subtree-split: 6c0831944229cadc6948c12833faad999fb6cd47
UJLengthArray() now provides the functionality of UJArraySize().
Closed
9f8383bff fix: don't export helper funcs JSON_XcodeObject git-subtree-dir: libs/ujson4c git-subtree-split: 9f8383bff7434cec7501d375ae0d6cef911f6095
UJSON4C exported one function inappropriately, likely a remnant of how the library was assembled. The export was removed in the library, so the partial workaround (anonymizing the symbol) is no longer needed.
|
Sorry for adding one more commit after requesting reviewing -- just discovered one more workaround for UJSON4C which could be now removed and I thought it would make sense to bundle it with this PR. |
droberts195
approved these changes
Jul 25, 2018
|
Thanks, Dave, added RM#207 to my TODOs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the external code - ODBC-Specification, c-timestamp, curl and ujson4c - as subtrees of the ODBC project.
Forked ujson4c library under elastic (https://github.com/elastic/ujson4c.git), to patch the (long standing) bugs and add some light extra functionality.
To that end, I've also removed one function from ODBC's code, which I've added into ujson4c's.
Googletest remains a
ExternalProject(cmake's lingo), pulled in only on request (i.e. building/running the unit tests).