Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies reporting batch #126

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Mar 12, 2019

This PR adds a Windows alternative to the dependency_report.sh.

This commit adds a Windows alternative to the dependency_report.sh.
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You could also remove dependency_report.sh to stop it getting out of sync with this or giving future maintainers twice as much work to do.

@bpintea
Copy link
Collaborator Author

bpintea commented Mar 12, 2019

You could also remove dependency_report.sh to stop it getting out of sync with this or giving future maintainers twice as much work to do.

True. I would do that however once https://github.com/elastic/release-manager/pull/558 is verified and merged, just to make sure that the RM can pick the report on a Windows machine as well, since I believe there's no other project doing it so far.

@bpintea bpintea merged commit e4d8536 into elastic:master Mar 12, 2019
@bpintea bpintea deleted the feat/dependency_report_bat branch March 12, 2019 15:06
bpintea added a commit that referenced this pull request Mar 12, 2019
This commit adds a Windows alternative to the dependency_report.sh.

(cherry picked from commit e4d8536)
bpintea added a commit that referenced this pull request Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh.

(cherry picked from commit e4d8536)
bpintea added a commit that referenced this pull request Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh.

(cherry picked from commit e4d8536)
bpintea added a commit that referenced this pull request Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh.

(cherry picked from commit e4d8536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants