Add dependencies reporting batch #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Windows alternative to the dependency_report.sh.
droberts195
approved these changes
Mar 12, 2019
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM
You could also remove dependency_report.sh to stop it getting out of sync with this or giving future maintainers twice as much work to do.
Collaborator
Author
True. I would do that however once https://github.com/elastic/release-manager/pull/558 is verified and merged, just to make sure that the RM can pick the report on a Windows machine as well, since I believe there's no other project doing it so far. |
bpintea
added a commit
that referenced
this pull request
Mar 12, 2019
This commit adds a Windows alternative to the dependency_report.sh. (cherry picked from commit e4d8536)
This was referenced Mar 13, 2019
Closed
bpintea
added a commit
that referenced
this pull request
Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh. (cherry picked from commit e4d8536)
bpintea
added a commit
that referenced
this pull request
Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh. (cherry picked from commit e4d8536)
bpintea
added a commit
that referenced
this pull request
Mar 19, 2019
This commit adds a Windows alternative to the dependency_report.sh. (cherry picked from commit e4d8536)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Windows alternative to the dependency_report.sh.