Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency report generation #17

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Dependency report generation #17

merged 2 commits into from
Aug 23, 2018

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Aug 22, 2018

The PR adds 3rd party deps report, as detailed in https://github.com/elastic/release-manager/issues/207.
The generation script itself is copied from ML repo, as well as the licenses storage layout.

- reused ML's script and licenses layout
@bpintea bpintea mentioned this pull request Aug 22, 2018
Closed
# Because of this, the field order is important - in each per-component CSV
# file the fields must be in the order shown above.
#
# Lifted from https://github.com/elastic/machine-learning-cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no need for this comment. In any case that's the URL of the old repo, the new one is https://github.com/elastic/ml-cpp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed the entire line, then.

Copy link
Collaborator

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

which also contained the old ML URL.
@bpintea bpintea merged commit 363da30 into elastic:master Aug 23, 2018
@bpintea bpintea deleted the feature/dependency_report branch August 23, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants