Enh: trace in-driver execution time. Extended logging buffer #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility to account for the time the execution spends within the driver. For that, it simply adds up the ticks accounted between entering and exiting any ODBC API call. With it, now one can estimate roughly how much time the driver code runs, as well as how long the driver waits for the REST calls. This time accounting is done globally and possibly across multiple threads. Its mostly useful with single-threaded use, though. The commit also adds the possibility to use a much larger logging "extended" buffer. This is useful in troubleshooting cases where larger logging meesages are required (such as when an entire server REST reply is JSON object is needed). Both of these features are disabled by default (for all build types).
edsavage
approved these changes
Aug 16, 2019
driver/odbc.c
Outdated
| @@ -24,20 +24,16 @@ | |||
| RET_HDIAGS(hnd, SQL_STATE_HYC00); \ | |||
| } while (0) | |||
|
|
|||
| #ifdef WITH_OAPI_TIMING | |||
| volatile LONG64 api_ticks = 0; | |||
| clock_t thread_local in_ticks; | |||
There was a problem hiding this comment.
explicitly initialise in_ticks
explicitly init global var
bpintea
added a commit
that referenced
this pull request
Aug 28, 2019
* Enh: trace in-driver execution time; ext log buff. This commit adds the possibility to account for the time the execution spends within the driver. For that, it simply adds up the ticks accounted between entering and exiting any ODBC API call. With it, now one can estimate roughly how much time the driver code runs, as well as how long the driver waits for the REST calls. This time accounting is done globally and possibly across multiple threads. Its mostly useful with single-threaded use, though. The commit also adds the possibility to use a much larger logging "extended" buffer. This is useful in troubleshooting cases where larger logging meesages are required (such as when an entire server REST reply is JSON object is needed). Both of these features are disabled by default (for all build types). * addressing PR review note explicitly init global var (cherry picked from commit 259b724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to account for the time the execution
spends within the driver. For that, it simply adds up the ticks
accounted between entering and exiting any ODBC API call.
With it, now one can estimate roughly how much time the driver code
runs, as well as how long the driver waits for the REST calls (previously
available).
This time accounting is done globally and possibly across multiple
threads. Its mostly useful with single-threaded use, though.
The PR also adds the possibility to use a much larger logging
"extended" buffer. This is useful in troubleshooting cases where larger
logging meesages are required (such as when an entire server REST reply
is JSON object is needed).
Both of these features are disabled by default (for all build types).