CBOR support for result sets #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this ends up to simply the spec file a bit and removes some unnecessary code in the library.
This commit extends the CBOR support with the ability to read the CBOR-encapsulated result sets. The commit also makes fetching data more efficient with the SQLGetData() (the alternative to the generally more efficient SQLBindCol()). The implementation still uses punctual column binding and unbinding, but SQLFetch() will now cache the source JSON/CBOR object into IRD's records and will no longer walk the entire list of instantied ARD records all the way to the ad-hoc bound column. Counting the total number of rows returned for a query has been changed to cope with ES's use of indefinite-size arrays, to avoid iterating twice over the rows in a page.
bpintea
added
>feature
edsavage
approved these changes
Aug 16, 2019
driver/queries.c
Outdated
| } | ||
| if (msg) { | ||
| res = ascii_c2w((SQLCHAR *)msg, wbuff, SQL_MAX_MESSAGE_LENGTH - 1); | ||
| wmsg = 0 < res ? wbuff : NULL; |
There was a problem hiding this comment.
This logic could be slightly simplified if wmsg is initialised to NULL above
There was a problem hiding this comment.
updated.
I was avoiding the potentially superfluous assignment (in case msg != NULL and 0 < res), but that's a thing the compiler can easily optimize away and this is anyways executed on the error case, so simplification is welcome here.
thanks.
- slight code simplification
bpintea
added a commit
that referenced
this pull request
Aug 28, 2019
* cbor: add source files individually to the project - this ends up to simply the spec file a bit and removes some unnecessary code in the library. * add CBOR support for result sets This commit extends the CBOR support with the ability to read the CBOR-encapsulated result sets. The commit also makes fetching data more efficient with the SQLGetData() (the alternative to the generally more efficient SQLBindCol()). The implementation still uses punctual column binding and unbinding, but SQLFetch() will now cache the source JSON/CBOR object into IRD's records and will no longer walk the entire list of instantied ARD records all the way to the ad-hoc bound column. Counting the total number of rows returned for a query has been changed to cope with ES's use of indefinite-size arrays, to avoid iterating twice over the rows in a page. * addressing PR review comments - slight code simplification (cherry picked from commit 4fc9197)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the CBOR support with the ability to read the
CBOR-encapsulated result sets.
The PR also makes fetching data more efficient with the SQLGetData()
(the alternative to the generally more efficient SQLBindCol()). The
implementation still uses punctual column binding and unbinding, but
SQLFetch() will now cache the source JSON/CBOR object into IRD's records
and will no longer walk the entire list of instantied ARD records all
the way to the ad-hoc bound column.
Counting the total number of rows returned for a query has been changed
to cope with ES's use of indefinite-size arrays, to avoid iterating
twice over the rows in a page.