CBOR support for parameters #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the support for sending the paramters encapsulated as CBOR. The implementation makes use of the already available paramter conversion functionality, which prepares the parameters as string values. Consequently, except NULL values (and type), the values will be sent as strings and have the server do a final conversion to the signaled SQL type (which is actually also the case with JSON).
bpintea
added
>feature
- for SQL_VARCHAR targets, the JSON parameter serialization adds the quotes, which need to be stripped before CBOR-packing the result. This commit also change the integer types of two vars, to avoid signed/unsigned comparision warnings.
droberts195
approved these changes
Aug 27, 2019
driver/queries.c
Outdated
| * but: (1) it's a simplified and tested implementation; (2) the overall | ||
| * performance impact is negligible with this driver's currently intended | ||
| * usage pattern (SELECTs only, fetching data volume far outweighing | ||
| * query's); (3) the server will convert the received value according to the |
There was a problem hiding this comment.
nit: "querys" should not have an apostrophe
There was a problem hiding this comment.
Thanks, addressed.
- correct comment phrasing.
bpintea
added a commit
that referenced
this pull request
Aug 28, 2019
* CBOR support for parameters This commit adds the support for sending the paramters encapsulated as CBOR. The implementation makes use of the already available paramter conversion functionality, which prepares the parameters as string values. Consequently, except NULL values (and type), the values will be sent as strings and have the server do a final conversion to the signaled SQL type (which is actually also the case with JSON). * split CBOR param value encoding by meta type - for SQL_VARCHAR targets, the JSON parameter serialization adds the quotes, which need to be stripped before CBOR-packing the result. This commit also change the integer types of two vars, to avoid signed/unsigned comparision warnings. * address PR review note - correct comment phrasing. (cherry picked from commit 758b8e2)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for sending the parameters encapsulated as
CBOR.
The implementation makes use of the already available parameter conversion
functionality, which prepares the parameter values as strings.
Consequently, except NULL values (and type), the values will be sent as
strings and have the server do a final conversion to the signaled SQL
type (which is actually also the case with JSON).