Skip to content

Add CBOR integration testing #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Aug 27, 2019

This PR adds a re-run of the integration tests, but carried over
CBOR.

The PR also enables parameter testing, but modifying the "protocol"
tests and adding an equality test with a parameter for each of them; the
paramter is the same value that the tests use to fetch from the server.

With this PR the application now queries the name of the cluster to
match the cataog name against (so that it can be run against nightly
build or a local compmilation easily).

This commit adds a re-run of the integration tests, but carried over
CBOR.

The commit also enables parameter testing, but modifying the "protocol"
tests and adding an equality test with a parameter for each of them; the
paramter is the same value that the tests use to fetch from the server.

With this commit the application now queries the name of the cluster to
match the cataog name against (so that it can be run against nightly
build or a local compmilation easily).
@bpintea bpintea added v8.0.0-alpha1 >test PRs targeting exclusively the testing framework v7.4.0 labels Aug 27, 2019
@bpintea bpintea mentioned this pull request Aug 27, 2019
5 tasks
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 2572afc into elastic:master Aug 29, 2019
@bpintea bpintea deleted the test/pack_cbor_integration branch August 29, 2019 10:29
bpintea added a commit that referenced this pull request Aug 29, 2019
This commit adds a re-run of the integration tests, but carried over
CBOR.

The commit also enables parameter testing, but modifying the "protocol"
tests and adding an equality test with a parameter for each of them; the
paramter is the same value that the tests use to fetch from the server.

With this commit the application now queries the name of the cluster to
match the cataog name against (so that it can be run against nightly
build or a local compmilation easily).

(cherry picked from commit 2572afc)
@bpintea bpintea mentioned this pull request Sep 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test PRs targeting exclusively the testing framework v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants