Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown to select data encapsulation format #180

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Aug 29, 2019

This PR adds the configuration to the editor form to allow selecting
between JSON and CBOR as data encapsulation.

The text labels on the Misc panel have been left aligned.

Also the Logging and Misc pannels have been swapped, to have Logging
ever so slightly easier to spot.

This commit adds the configuration to the editor form to allow selecting
between JSON and CBOR as data encapsulation.

Also the Logging and Misc pannels have been swapped, to have Logging
ever so slightly easier to spot.
@bpintea bpintea added >feature Applicable to PRs adding new functionality v8.0.0-alpha1 v7.5.0 labels Aug 29, 2019
@bpintea bpintea requested a review from codebrain August 29, 2019 10:28
@bpintea bpintea mentioned this pull request Aug 29, 2019
5 tasks
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bpintea bpintea merged commit e003889 into elastic:master Sep 10, 2019
@bpintea bpintea deleted the feat/pack_cbor_gui branch September 10, 2019 09:56
@bpintea bpintea mentioned this pull request Sep 10, 2019
Closed
bpintea added a commit that referenced this pull request Sep 10, 2019
This commit adds the configuration to the editor form to allow selecting
between JSON and CBOR as data encapsulation.

Also the Logging and Misc pannels have been swapped, to have Logging
ever so slightly easier to spot.

(cherry picked from commit e003889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature Applicable to PRs adding new functionality v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants