SQLRowCount: always return row set size #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit SQLRowCount() will always return the size of current row set, also in the case a cursor is present. The previous implementation returned 0 when a cursor was present, since the function can't evaluate the total result set size (without actually fetching it all) and applications shouldn't rely on this result. The driver - that internally also uses the function for SYS queries - assumed that ES/SQL will never return a cursor for SYS commands. This seems however not to be a valid assumption.
bpintea
added a commit
that referenced
this pull request
Sep 5, 2019
With this commit SQLRowCount() will always return the size of current row set, also in the case a cursor is present. The previous implementation returned 0 when a cursor was present, since the function can't evaluate the total result set size (without actually fetching it all) and applications shouldn't rely on this result. The driver - that internally also uses the function for SYS queries - assumed that ES/SQL will never return a cursor for SYS commands. This seems however not to be a valid assumption. (cherry picked from commit 1058242)
bpintea
added a commit
that referenced
this pull request
Sep 10, 2019
With this commit SQLRowCount() will always return the size of current row set, also in the case a cursor is present. The previous implementation returned 0 when a cursor was present, since the function can't evaluate the total result set size (without actually fetching it all) and applications shouldn't rely on this result. The driver - that internally also uses the function for SYS queries - assumed that ES/SQL will never return a cursor for SYS commands. This seems however not to be a valid assumption. (cherry picked from commit 1058242)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
SQLRowCount()will always return the size of currentrow set, also in the case a cursor is present.
The previous implementation returned 0 when a cursor was present, since
the function can't evaluate the total result set size (without actually
fetching it all) and applications shouldn't rely on this result.
The driver - that internally also uses the function for SYS queries -
assumed that ES/SQL will never return a cursor for SYS commands. This
seems however not to be a valid assumption.