Convert ES/BOOLEAN to SQL C BIT #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES/BOOLEAN is used in results to catalog queries, like SYS TYPES (used by SQLGetTypeInfo()). Since this is a non-ODBC standard type, some applications (like Excel) have troubles converting it to the coresponding standard integer required by the standard. This commit changes the handling of ES/BOOLEAN, converting it to the BIT type (used by ODBC for bools). The driver still accepts the ES/BOOLEAN type from the application, though, if this is ES types-aware.
- long long is on 8 bytes also on x86
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES/BOOLEAN is used in results to catalog queries, like SYS TYPES (used by SQLGetTypeInfo() API). Since this is a non-ODBC standard type, some applications (like Excel) have troubles automatically converting it to the corresponding integer required by the standard.
This PR changes the handling of ES/BOOLEAN, converting it to the BIT type, meant by ODBC for booleans.
The driver still accepts the ES/BOOLEAN type from the application, though, if this is ES types-aware.