Java Api clean up: remove deprecated isShardsAcked (#28311)

This PR removes previously deprecated `isShardsAcked()` method in favour of `isShardsAcknowledged()` on `CreateIndexResponse`, `CreateIndexClusterStateUpdateResponse` and `RolloverResponse` Related to #27784 Follow-up of #27819
elastic · Jan 25, 2018 · 0c83240 · 0c83240
1 parent 261fb6a
commit 0c83240
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 31 deletions.
diff --git a/docs/reference/migration/migrate_7_0.asciidoc b/docs/reference/migration/migrate_7_0.asciidoc
@@ -31,6 +31,7 @@ Elasticsearch 6.x in order to be readable by Elasticsearch 7.x.
 * <<breaking_70_plugins_changes>>
 * <<breaking_70_analysis_changes>>
 * <<breaking_70_api_changes>>
+* <<breaking_70_java_changes>>
 
 
 include::migrate_7_0/aggregations.asciidoc[]
@@ -41,3 +42,4 @@ include::migrate_7_0/mappings.asciidoc[]
 include::migrate_7_0/search.asciidoc[]
 include::migrate_7_0/plugins.asciidoc[]
 include::migrate_7_0/api.asciidoc[]
+include::migrate_7_0/java.asciidoc[]
diff --git a/docs/reference/migration/migrate_7_0/java.asciidoc b/docs/reference/migration/migrate_7_0/java.asciidoc
@@ -0,0 +1,8 @@
+[[breaking_70_java_changes]]
+=== Java API changes
+
+==== `isShardsAcked` deprecated in `6.2` has been removed
+
+`isShardsAcked` has been replaced by `isShardsAcknowledged` in
+`CreateIndexResponse`, `RolloverResponse` and
+`CreateIndexClusterStateUpdateResponse`.
diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexResponse.java b/server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexResponse.java
@@ -85,18 +85,6 @@ public void writeTo(StreamOutput out) throws IOException {
         }
     }
 
-    /**
-     * Returns true if the requisite number of shards were started before
-     * returning from the index creation operation. If {@link #isAcknowledged()}
-     * is false, then this also returns false.
-     * 
-     * @deprecated use {@link #isShardsAcknowledged()}
-     */
-    @Deprecated
-    public boolean isShardsAcked() {
-        return shardsAcknowledged;
-    }
-
     /**
      * Returns true if the requisite number of shards were started before
      * returning from the index creation operation. If {@link #isAcknowledged()}

diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/rollover/RolloverResponse.java b/server/src/main/java/org/elasticsearch/action/admin/indices/rollover/RolloverResponse.java
@@ -111,18 +111,6 @@ public boolean isAcknowledged() {
         return acknowledged;
     }
 
-    /**
-     * Returns true if the requisite number of shards were started in the newly
-     * created rollover index before returning. If {@link #isAcknowledged()} is
-     * false, then this will also return false.
-     * 
-     * @deprecated use {@link #isShardsAcknowledged()}
-     */
-    @Deprecated
-    public boolean isShardsAcked() {
-        return shardsAcknowledged;
-    }
-
     /**
      * Returns true if the requisite number of shards were started in the newly
      * created rollover index before returning. If {@link #isAcknowledged()} is

diff --git a/...er/src/main/java/org/elasticsearch/cluster/ack/CreateIndexClusterStateUpdateResponse.java b/...er/src/main/java/org/elasticsearch/cluster/ack/CreateIndexClusterStateUpdateResponse.java
@@ -33,14 +33,7 @@ public CreateIndexClusterStateUpdateResponse(boolean acknowledged, boolean shard
 
     /**
      * Returns whether the requisite number of shard copies started before the completion of the operation.
-     * 
-     * @deprecated use {@link #isShardsAcknowledged()}
      */
-    @Deprecated
-    public boolean isShardsAcked() {
-        return shardsAcknowledged;
-    }
-
     public boolean isShardsAcknowledged() {
         return shardsAcknowledged;
     }