Skip to content

Commit

Permalink
Painless: Add public member read/write access test. (#28156)
Browse files Browse the repository at this point in the history
  • Loading branch information
jdconrad authored Jan 9, 2018
1 parent 3fb0cb9 commit 5d795af
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
public class FeatureTest {
private int x;
private int y;
public int z;

/** empty ctor */
public FeatureTest() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ class org.elasticsearch.index.mapper.IpFieldMapper$IpFieldType$IpScriptDocValues
# for testing.
# currently FeatureTest exposes overloaded constructor, field load store, and overloaded static methods
class org.elasticsearch.painless.FeatureTest only_fqn {
int z
()
(int,int)
int getX()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,9 @@ public void testPrimitivesHaveMethods() {
assertEquals("5", exec("int x = 5; return x.toString();"));
assertEquals(0, exec("int x = 5; return x.compareTo(5);"));
}

public void testPublicMemberAccess() {
assertEquals(5, exec("org.elasticsearch.painless.FeatureTest ft = new org.elasticsearch.painless.FeatureTest();" +
"ft.z = 5; return ft.z;"));
}
}

0 comments on commit 5d795af

Please sign in to comment.