Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Async request disregards format request #110926

Closed
bpintea opened this issue Jul 16, 2024 · 3 comments · Fixed by #111104
Closed

ESQL: Async request disregards format request #110926

bpintea opened this issue Jul 16, 2024 · 3 comments · Fixed by #111104
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@bpintea
Copy link
Contributor

bpintea commented Jul 16, 2024

Description

An async request in text mode (POST _query/async?format=txt) will return a JSON body.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@kanoshiou
Copy link
Contributor

👋Hi, I would like to take on the task of addressing this issue using the second method, which involves returning the async parameters as headers. Could I give it a try?

Thank you!

@bpintea bpintea changed the title ESQL: Async request in txt mode returns empty body ESQL: Async request disregards format request Nov 27, 2024
@bpintea
Copy link
Contributor Author

bpintea commented Nov 27, 2024

Issue edited to reflect current behaviour (related, #109576 added HTTP headers with the async details).

@bpintea bpintea closed this as completed in 67ee034 Dec 9, 2024
bpintea pushed a commit to bpintea/elasticsearch that referenced this issue Dec 9, 2024
I've updated the listener for GET /_query/async/{id} to EsqlResponseListener, so it now accepts parameters (delimiter, drop_null_columns and format) like the POST /_query API. Additionally, I have added tests to verify the correctness of the code.

You can now set the format in the request parameters to specify the return style.

Closes elastic#110926
elasticsearchmachine pushed a commit that referenced this issue Dec 9, 2024
I've updated the listener for GET /_query/async/{id} to EsqlResponseListener, so it now accepts parameters (delimiter, drop_null_columns and format) like the POST /_query API. Additionally, I have added tests to verify the correctness of the code.

You can now set the format in the request parameters to specify the return style.

Closes #110926

Co-authored-by: kanoshiou <73424326+kanoshiou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants