Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] HeapAttackIT testLookupExplosionManyMatches failing #121481

Closed
elasticsearchmachine opened this issue Feb 1, 2025 · 5 comments · Fixed by #121565
Closed

[CI] HeapAttackIT testLookupExplosionManyMatches failing #121481

elasticsearchmachine opened this issue Feb 1, 2025 · 5 comments · Fixed by #121565
Assignees
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 1, 2025

Build Scans:

Reproduction Line:

./gradlew ":test:external-modules:test-esql-heap-attack:javaRestTest" --tests "org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT.testLookupExplosionManyMatches" -Dtests.seed=84260B8935292342 -Dtests.locale=kxv-IN -Dtests.timezone=ECT -Druntime.java=23

Applicable branches:
8.x

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

junit.framework.AssertionFailedError: Expected exception ResponseException but no exception was thrown

Issue Reasons:

  • [8.x] 2 failures in test testLookupExplosionManyMatches (0.4% fail rate in 564 executions)
  • [8.x] 2 failures in pipeline elasticsearch-periodic-platform-support (15.4% fail rate in 13 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Feb 1, 2025
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testLookupExplosionManyMatches (0.4% fail rate in 475 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 1, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies
Copy link
Contributor

@nik9000 , this one also somehow returned a result. I'd appreciate if you could take a look :)

[2025-02-01T23:45:53,242][ERROR][o.e.x.e.h.HeapAttackIT   ] [testLookupExplosionManyMatches] should have failed but got {took=94926, is_partial=false, columns=[{name=COUNT(location), type=long}], values=[[15000000]]}	

@alex-spies alex-spies added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 3, 2025
@nik9000
Copy link
Member

nik9000 commented Feb 3, 2025

Despite this saying "should have failed but didn't" this is actually a timeout. In the Verifier.

elasticsearch-periodic-platform-support #6126 / rhel-7_platform-support-unix

This one didn't fail:

[2025-02-01T23:44:18,304][INFO ][o.e.x.e.h.HeapAttackIT   ] [testLookupExplosionManyMatches] --> test testLookupExplosionManyMatches started querying
[2025-02-01T23:45:42,561][INFO ][o.e.m.j.JvmGcMonitorService] [test-cluster-1] [gc][249] overhead, spent [269ms] collecting in the last [1s]
[2025-02-01T23:45:47,579][INFO ][o.e.m.j.JvmGcMonitorService] [test-cluster-1] [gc][254] overhead, spent [253ms] collecting in the last [1s]
[2025-02-01T23:45:48,600][INFO ][o.e.m.j.JvmGcMonitorService] [test-cluster-1] [gc][255] overhead, spent [299ms] collecting in the last [1s]
[2025-02-01T23:45:53,241][INFO ][o.e.x.e.h.HeapAttackIT   ] [testLookupExplosionManyMatches] --> test testLookupExplosionManyMatches completed querying
[2025-02-01T23:45:53,242][ERROR][o.e.x.e.h.HeapAttackIT   ] [testLookupExplosionManyMatches] should have failed but got {took=94926, is_partial=false, columns=[{name=COUNT(location), type=long}], values=[[15000000]]}

elasticsearch-periodic-platform-support #6107 / windows-2022_checkpart1_platform-support-windows

Everything failed. The whole build seems broken.

elasticsearch-pull-request #53887 / part-1

Timeout in the Analyzer. In resolveEval.

@nik9000
Copy link
Member

nik9000 commented Feb 3, 2025

Timeout in the Analyzer. In resolveEval.

There isn't an eval in this test. I think that's some kind of other failure.

elasticsearchmachine pushed a commit that referenced this issue Feb 3, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close #121481 Close #121465
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Feb 3, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close elastic#121481 Close elastic#121465
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Feb 3, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close elastic#121481 Close elastic#121465
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Feb 3, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close elastic#121481 Close elastic#121465
alex-spies pushed a commit that referenced this issue Feb 4, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close #121481 Close #121465
elasticsearchmachine pushed a commit that referenced this issue Feb 4, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close #121481 Close #121465
elasticsearchmachine pushed a commit that referenced this issue Feb 4, 2025
* ESQL: Reenable heap attacks (#121565)

Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close #121481 Close #121465

* Unmute

---------

Co-authored-by: Alexander Spies <alexander.spies@elastic.co>
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this issue Feb 4, 2025
Reenables some heap attack tests, bumping their memory requirements to
try and force a failure on all CI machines. Previously some CI machines
weren't failing, invalidating the test on those machines.

Close elastic#121481 Close elastic#121465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants