Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices cat API doesn't list closed indices when filtered #16419

Closed
jlecour opened this issue Feb 3, 2016 · 4 comments · Fixed by #18545
Closed

Indices cat API doesn't list closed indices when filtered #16419

jlecour opened this issue Feb 3, 2016 · 4 comments · Fixed by #18545
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat good first issue low hanging fruit

Comments

@jlecour
Copy link
Contributor

jlecour commented Feb 3, 2016

Hi,

With the indices cat API, I can list my indices, either open or close.

→ curl http://127.0.0.1:9200/_cat/indices
       close partner_results-20150930
yellow open  partner_requests-20150929     1 1     17     0 230.3kb 230.3kb
yellow open  partner_results-20151102      5 1   4311     0   1.5mb   1.5mb
yellow open  search_requests-20150902      5 1     10     0  51.3kb  51.3kb

If I filter my results, I no longer see close indices :

→ curl http://127.0.0.1:9200/_cat/indices/\*_results-\*
yellow open  partner_results-20151102      5 1   4311     0   1.5mb   1.5mb

I didn't find the documentation about that so I don't know if it a bug or an undocumented behavior.

I thought there might be an argument for /_cat/indices to show all/open/close indices, but I haven't found anything.
@clintongormley clintongormley added >bug good first issue low hanging fruit help wanted adoptme :Data Management/CAT APIs Text APIs behind /_cat labels Feb 13, 2016
@debarshiraha
Copy link

I would like to start contributing by fixing this one, if this can be assigned to me!

@debarshiraha debarshiraha mentioned this issue Feb 19, 2016
Closed
@nik9000
Copy link
Member

nik9000 commented Feb 19, 2016

I would like to start contributing by fixing this one, if this can be assigned to me!

Grumble grumble it looks like you can't assign non-"elastic members" to issues. I was wrong! Anyway, consider it claimed.

@dadoonet dadoonet removed the help wanted adoptme label Feb 19, 2016
@dadoonet
Copy link
Member

@nik9000 In such a case, I think we can remove the adoptme label. I just updated the issue.

@nik9000
Copy link
Member

nik9000 commented Feb 19, 2016

@nik9000 In such a case, I think we can remove the adoptme label. I just updated the issue.

Thanks!

ywelsch added a commit to ywelsch/elasticsearch that referenced this issue May 24, 2016
@ywelsch
Expand wildcards to closed indices in /_cat/indices
1c3d7da 
Closes elastic#16419
Closes elastic#17395
@ywelsch ywelsch mentioned this issue May 24, 2016
Merged
ywelsch added a commit that referenced this issue May 25, 2016
@ywelsch
Expand wildcards to closed indices in /_cat/indices (#18545)
dee34c9 
Closed indices are already displayed when no indices are explicitly selected. This commit ensures that closed indices are also shown when wildcard filtering is used. It also addresses another issue that is caused by the fact that the cat action is based internally on 3 different cluster states (one when we query the cluster state to get all indices, one when we query cluster health, and one when we query indices stats). We currently fail the cat request when the user specifies a concrete index as parameter that does not exist. The implementation works as intended in that regard. It checks this not only for the first cluster state request, but also the subsequent indices stats one. This means that if the index is deleted before the cat action has queried the indices stats, it rightfully fails. In case the user provides wildcards (or no parameter at all), however, we fail the indices stats as we pass the resolved concrete indices to the indices stats request and fail to distinguish whether these indices have been resolved by wildcards or explicitly requested by the user. This means that if an index has been deleted before the indices stats request gets to execute, we fail the overall cat request. The fix is to let the indices stats request do the resolving again and not pass the concrete indices.

Closes #16419
Closes #17395
ywelsch added a commit that referenced this issue May 25, 2016
@ywelsch
Expand wildcards to closed indices in /_cat/indices (#18545)
beb759c 
Closed indices are already displayed when no indices are explicitly selected. This commit ensures that closed indices are also shown when wildcard filtering is used. It also addresses another issue that is caused by the fact that the cat action is based internally on 3 different cluster states (one when we query the cluster state to get all indices, one when we query cluster health, and one when we query indices stats). We currently fail the cat request when the user specifies a concrete index as parameter that does not exist. The implementation works as intended in that regard. It checks this not only for the first cluster state request, but also the subsequent indices stats one. This means that if the index is deleted before the cat action has queried the indices stats, it rightfully fails. In case the user provides wildcards (or no parameter at all), however, we fail the indices stats as we pass the resolved concrete indices to the indices stats request and fail to distinguish whether these indices have been resolved by wildcards or explicitly requested by the user. This means that if an index has been deleted before the indices stats request gets to execute, we fail the overall cat request. The fix is to let the indices stats request do the resolving again and not pass the concrete indices.

Closes #16419
Closes #17395
ywelsch added a commit that referenced this issue May 25, 2016
@ywelsch
Expand wildcards to closed indices in /_cat/indices (#18545)
0720eb5 
Closed indices are already displayed when no indices are explicitly selected. This commit ensures that closed indices are also shown when wildcard filtering is used. It also addresses another issue that is caused by the fact that the cat action is based internally on 3 different cluster states (one when we query the cluster state to get all indices, one when we query cluster health, and one when we query indices stats). We currently fail the cat request when the user specifies a concrete index as parameter that does not exist. The implementation works as intended in that regard. It checks this not only for the first cluster state request, but also the subsequent indices stats one. This means that if the index is deleted before the cat action has queried the indices stats, it rightfully fails. In case the user provides wildcards (or no parameter at all), however, we fail the indices stats as we pass the resolved concrete indices to the indices stats request and fail to distinguish whether these indices have been resolved by wildcards or explicitly requested by the user. This means that if an index has been deleted before the indices stats request gets to execute, we fail the overall cat request. The fix is to let the indices stats request do the resolving again and not pass the concrete indices.

Closes #16419
Closes #17395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand wildcards to closed indices in /_cat/indices ywelsch/elasticsearch
5 participants
@jlecour @clintongormley @nik9000 @dadoonet @debarshiraha