-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java high-level REST client completeness for xpack APIs #29827
Comments
Original comment by @pickypg: The Ideally we will even be removing it once we get to Metricbeat-based monitoring data. |
Original comment by @javanna: I updated the description of the issue by assigning each API a rank from 1 to 3 based on how difficult it should be to add support for it to the high-level REST client. Criterias were mainly how big the request is to serialize and how big the response is to parse back. |
Original comment by @tvernum: @javanna Did you have a plan about how we'd ship an X-Pack enabled client?
But there's options to have separate clients per feature (I can't see a reason to do that) or to take the same approach as the current |
The `:x-pack:protocol` project is an implementation detail shared by the xpack projects and the high level rest client and really doesn't deserve its own maven coordinants and published javadoc. This change bundles `:x-pack:protocol` into the high level rest client. Relates to elastic#29827
One down! |
The `:x-pack:protocol` project is an implementation detail shared by the xpack projects and the high level rest client and really doesn't deserve its own maven coordinants and published javadoc. This change bundles `:x-pack:protocol` into the high level rest client. Relates to #29827
The `:x-pack:protocol` project is an implementation detail shared by the xpack projects and the high level rest client and really doesn't deserve its own maven coordinants and published javadoc. This change bundles `:x-pack:protocol` into the high level rest client. Relates to #29827
Relates #29827 This implementation behaves like the current transport client, that you basically cannot configure a Watch POJO representation as an argument to the put watch API, but only a bytes reference. You can use the the `WatchSourceBuilder` from the `org.elasticsearch.plugin:x-pack-core` dependency to build watches. This commit also changes the license type to trial, so that watcher is available in high level rest client tests. /cc @hub-cap
Relates elastic#29827 This implementation behaves like the current transport client, that you basically cannot configure a Watch POJO representation as an argument to the put watch API, but only a bytes reference. You can use the the `WatchSourceBuilder` from the `org.elasticsearch.plugin:x-pack-core` dependency to build watches. This commit also changes the license type to trial, so that watcher is available in high level rest client tests.
Relates #29827 This implementation behaves like the current transport client, that you basically cannot configure a Watch POJO representation as an argument to the put watch API, but only a bytes reference. You can use the the `WatchSourceBuilder` from the `org.elasticsearch.plugin:x-pack-core` dependency to build watches. This commit also changes the license type to trial, so that watcher is available in high level rest client tests.
This commit adds a security client to the high level rest client, which includes an implementation for the put user api. As part of these changes, the request and response classes were moved to the x-pack protocol project and licensed under the Apache 2 license. The PutUserRequest previously performed some validation of the username that really is more fitting for the server validation. This validation has been removed to reduce the amount of logic on the client side and also reduce the number of classes that would need to be moved to the protocol project. The removed validation now happens in the transport action. See elastic#29827
This commits adds support for the Get Application Privileges API to the HLRC Relates: #29827
This commits adds support for the Get Application Privileges API to the HLRC Relates: #29827
This commits adds support for the Get Roles API to the HLRC Relates: #29827
This commits adds support for the Get Roles API to the HLRC Relates: #29827
* HLRC: Add delete user action It adds delete user action to the high level rest client. Relates #29827
* HLRC: Add delete user action It adds delete user action to the high level rest client. Relates #29827
This commit adds the Get Deprecation Info API and associated documentation. Relates elastic#29827
Relates to elastic#29827
This commit adds the Get Deprecation Info API and associated documentation. Relates #29827
This commit adds the Get Deprecation Info API and associated documentation. Note: This commit is different from master as it adds back the _xpack portion of the API. Relates #29827
Original comment by @javanna:
This is the xpack side of #27205 . This is a meta issue to track completeness of the Java REST high-level Client in terms of supported xpack API. The following list includes all the REST API that xpack exposes to date, and that are also exposed by the Transport Client. The ones marked as done are already supported by the high-level REST client, while the others need to be added. Every group is sorted based on an estimation around how important the API is, from more important to less important. Each API is also assigned a rank from 1 to 3 that expresses how difficult adding support for it is expected to be.
Please Note The existing actions are in x-pack/ which is governed by the Elastic License, not the Apache License. Engineers who take these should strive to pull the Actions into Apache License controlled territory, so the high level rest client does not use any Elastic License bits. These should live in
x-pack/protocol
, which is OSS.Please also note The APIs themselves should follow the spec for how they are named. This means they should be in the XPackClient, not the HighLevelRestClient. This would mean you end up with
hlRestClient.xpack().watcher()
as an examplePlease Please also also note Prepend your commit msgs with
HLRC:
Watcher API
Machine Learning API
Machine Learning REST only API
Security API
Security REST only API
Miscellaneous API
Graph API
Licensing API
Rollup
Migration
Monitoring API
monitoring bulkIndex Lifecycle Management
See #33100
CCR
See #33824
The text was updated successfully, but these errors were encountered: