Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository GCS test deprecated settings is broken #30638

Closed
jasontedor opened this issue May 16, 2018 · 5 comments
Closed

Repository GCS test deprecated settings is broken #30638

jasontedor opened this issue May 16, 2018 · 5 comments
Assignees
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI

Comments

@jasontedor
Copy link
Member

jasontedor commented May 16, 2018

This assertion:

assertWarnings(
"Setting [application_name] in repository settings is deprecated, it must be specified in the client settings instead",
"Setting [http.read_timeout] in repository settings is deprecated, it must be specified in the client settings instead",
"Setting [http.connect_timeout] in repository settings is deprecated, it must be specified in the client settings instead");

fails reliably in 6.x This appears to be because code that would produce such messages never appears in production code.

@jasontedor jasontedor added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels May 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jasontedor
Copy link
Member Author

jasontedor commented May 16, 2018

I pushed 7e12417.

@albertzaharovits
Copy link
Contributor

Apologies for the blunder.
I have botched the backport and autocomplete for the test command jumped to another command ./gradlew :plugins:repository-gcs:clean :plugins:repository-gcs:assemble .

On it.

@tlrx
Copy link
Member

tlrx commented May 16, 2018

And sorry for not having caught this in the review.

albertzaharovits added a commit that referenced this issue May 16, 2018
@albertzaharovits
Copy link
Contributor

I have pushed 0aafb06 and unawaitsfixed the test. I am sorry for the sloppiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

4 participants