-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: Align class packages in sql-proto and shared-proto projects #31593
Labels
Comments
Pinging @elastic/es-search-aggs |
I think we can kill the word
|
+1 |
imotov
added a commit
to imotov/elasticsearch
that referenced
this issue
Jun 27, 2018
- renames project sql-proto-> sql-action, - renames package sql.plugin to sql.action - renames project sql-shared-client -> sql-client - renames package sql.shard.client to sql.client - renames project sql-shared-proto -> sql-proto Closes elastic#31593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like a left-over from the various class movements:
the package name of the
sql-proto
project issql.plugin
. This is incorrect and misleading since that's the package of the server. It should be changed to something more appropriate likesql.proto
or (to avoid a cycle with 2 below) `sql.proto.action.the package name of the shared-proto project is
sql.proto
. Due to 1 above, it should besql.proto.shared
or (since that creates a cycle betweenproto.shared
andproto
) tosql.shared.proto
orsql.proto.common
.That is, the package name should properly convey the project name and the hierarchy (
sql-proto
depends onshared-proto
not vice versa) without splitting an existing package name.The text was updated successfully, but these errors were encountered: