Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT Fails on Upper and lower casing functions #32589

Closed
colings86 opened this issue Aug 2, 2018 · 6 comments
Closed

org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT Fails on Upper and lower casing functions #32589

colings86 opened this issue Aug 2, 2018 · 6 comments
Assignees
@astefan
Labels
:Analytics/SQL SQL querying >bug >test-failure Triaged test failures from CI v6.5.0 v7.0.0-beta1

Comments

@colings86
Copy link
Contributor

Build URL:

http://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=amazon/2595

Reproduce commands:

./gradlew :x-pack:qa:sql:no-security:integTestRunner \
  -Dtests.seed=5870E6CDF96A6756 \
  -Dtests.class=org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT \
  -Dtests.method="test {string-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstName}" \
  -Dtests.security.manager=true \
  -Dtests.locale=tr \
  -Dtests.timezone=America/Dawson

./gradlew :x-pack:qa:sql:no-security:integTestRunner \
  -Dtests.seed=5870E6CDF96A6756 \
  -Dtests.class=org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT \
  -Dtests.method="test {string-functions.testSelectInsertWithLcaseAndLengthWithOrderBy}" \
  -Dtests.security.manager=true \
  -Dtests.locale=tr \
  -Dtests.timezone=America/Dawson

./gradlew :x-pack:qa:sql:no-security:integTestRunner \
  -Dtests.seed=5870E6CDF96A6756 \
  -Dtests.class=org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT \
  -Dtests.method="test {string-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstNameWithOrderByAndGroupBy}" \
  -Dtests.security.manager=true \
  -Dtests.locale=tr \
  -Dtests.timezone=America/Dawson

Errors looks to be expecting diacritics on the output but not finding them and instead finding a normalised character. e.g.:

14:46:33 FAILURE 0.08s | JdbcSqlSpecIT.test {string-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstName} <<< FAILURES!
14:46:33    > Throwable #1: org.junit.ComparisonFailure: Different result for column [f], entry [2] expected:<Ala[İ]n> but was:<Ala[I]n>
14:46:33    > 	at __randomizedtesting.SeedInfo.seed([5870E6CDF96A6756:D024D91757960AAE]:0)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.nosecurity.JdbcSqlSpecIT.string-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstName(string-functions.sql-spec:145)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.JdbcAssert.doAssertResultSetData(JdbcAssert.java:199)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.JdbcAssert.assertResultSetData(JdbcAssert.java:133)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.JdbcAssert.assertResultSets(JdbcAssert.java:58)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.JdbcAssert.assertResultSets(JdbcAssert.java:45)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.SpecBaseIntegrationTestCase.assertResults(SpecBaseIntegrationTestCase.java:123)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.SqlSpecTestCase.doTest(SqlSpecTestCase.java:66)
14:46:33    > 	at org.elasticsearch.xpack.qa.sql.jdbc.SpecBaseIntegrationTestCase.test(SpecBaseIntegrationTestCase.java:88)
14:46:33    > 	at java.lang.Thread.run(Thread.java:748)
@colings86 colings86 added >test-failure Triaged test failures from CI :Analytics/SQL SQL querying labels Aug 2, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86
Copy link
Contributor Author

Muted these tests on master in 4cdbb42

colings86 added a commit that referenced this issue Aug 2, 2018
@colings86
Mutes failing SQL string function tests due to #32589
4cdbb42
dnhatn added a commit that referenced this issue Aug 3, 2018
@dnhatn
Merge branch 'master' into ccr
6eeb628 
* master:
  HLRC: Move commercial clients from XPackClient (#32596)
  Add cluster UUID to Cluster Stats API response (#32206)
  Security: move User to protocol project (#32367)
  [TEST] Test for shard failures, add debug to testProfileMatchesRegular
  Minor fix for javadoc (applicable for java 11). (#32573)
  Painless: Move Some Lookup Logic to PainlessLookup (#32565)
  TEST: Avoid merges in testSeqNoAndCheckpoints
  [Rollup] Remove builders from HistoGroupConfig (#32533)
  Mutes failing SQL string function tests due to #32589
  fixed elements in array of produced terms (#32519)
  INGEST: Enable default pipelines (#32286)
  Remove cluster state initial customs (#32501)
  Mutes LicensingDocumentationIT due to #32580
  [ML] Remove multiple_bucket_spans (#32496)
  [ML] Rename JobProvider to JobResultsProvider (#32551)
  Correct minor typo in explain.asciidoc for HLRC
  Build: Add elastic maven to repos used by BuildPlugin (#32549)
  Clarify the error message when a pipeline agg is used in the 'order' parameter. (#32522)
  Revert "[test] turn on host io cache for opensuse (#32053)"
  Enable packaging tests on suse boxes
  [ML] Improve error when no available field exists for rule scope (#32550)
  [ML] Improve error for functions with limited rule condition support (#32548)
  Painless: Clean Up PainlessField (#32525)
  Add @AwaitsFix for #32554
  Remove broken @link in Javadoc
  Scripting: Conditionally use java time api in scripting (#31441)
  [ML] Fix thread leak when waiting for job flush (#32196) (#32541)
  Add AwaitsFix to failing test - see #32546
  Core: Minor size reduction for AbstractComponent (#32509)
  SQL: Added support for string manipulating functions with more than one parameter (#32356)
  [DOCS] Reloadable Secure Settings (#31713)
  Watcher: Reenable HttpSecretsIntegrationTests#testWebhookAction test (#32456)
  [Rollup] Remove builders from TermsGroupConfig (#32507)
  Use hostname instead of IP with SPNEGO test (#32514)
  Switch x-pack rolling restart to new style Requests (#32339)
  NETWORKING: Fix Netty Leaks by upgrading to 4.1.28 (#32511)
  [DOCS] Small fixes in rule configuration page (#32516)
  Painless: Clean up PainlessMethod (#32476)
  Build: Remove shadowing from benchmarks (#32475)
  Docs: Add all JDKs to CONTRIBUTING.md
  Add licensing enforcement for FIPS mode (#32437)
  SQL: Add test for handling of partial results (#32474)
  Mute testFilterCacheStats
  [ML][DOCS] Fix typo applied_to => applies_to
  Scripting: Fix painless compiler loader to know about context classes (#32385)
This was referenced Aug 3, 2018
Closed
Merged
dakrone pushed a commit that referenced this issue Aug 3, 2018
@colings86 @dakrone
Mutes failing SQL string function tests due to #32589
9925fe1
@dakrone
Copy link
Member

dakrone commented Aug 3, 2018

Another instance of this on 6.x: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+release-tests/921/console

I backported Colin's mute to the 6.x branch

@astefan
Copy link
Contributor

astefan commented Aug 3, 2018

Thanks @dakrone. PR coming in: #32604

dnhatn added a commit that referenced this issue Aug 6, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
e4a919f 
* 6.x:
  [Kerberos] Use canonical host name (#32588)
  Cross-cluster search: preserve cluster alias in shard failures (#32608)
  [TEST] Allow to run in FIPS JVM (#32607)
  Handle AlreadyClosedException when bumping primary term
  [Test] Add ckb to the list of unsupported languages (#32611)
  SCRIPTING: Move Aggregation Scripts to their own context (#32068) (#32629)
  [TEST] Enhance failure message when bulk updates have failures
  [ML] Add ML result classes to protocol library (#32587)
  Suppress LicensingDocumentationIT.testPutLicense in release builds (#32613)
  [Rollup] Improve ID scheme for rollup documents (#32558)
  Mutes failing SQL string function tests due to #32589
  Suppress Wildfly test in FIPS JVMs (#32543)
  Add cluster UUID to Cluster Stats API response (#32206)
  [ML] Add some ML config classes to protocol library (#32502)
  [TEST]Split transport verification mode none tests (#32488)
  [Rollup] Remove builders from DateHistogramGroupConfig (#32555)
  [ML] Add Detector config classes to protocol library (#32495)
  [Rollup] Remove builders from MetricConfig (#32536)
  Fix race between replica reset and primary promotion (#32442)
  HLRC: Move commercial clients from XPackClient (#32596)
  Security: move User to protocol project (#32367)
  Minor fix for javadoc (applicable for java 11). (#32573)
  Painless: Move Some Lookup Logic to PainlessLookup (#32565)
  Core: Minor size reduction for AbstractComponent (#32509)
  INGEST: Enable default pipelines (#32286) (#32591)
  TEST: Avoid merges in testSeqNoAndCheckpoints
  [Rollup] Remove builders from HistoGroupConfig (#32533)
  fixed elements in array of produced terms (#32519)
  Mutes ReindexFailureTests.searchFailure dues to #28053
  Mutes LicensingDocumentationIT due to #32580
  Remove the SATA controller from OpenSUSE box
  [ML] Rename JobProvider to JobResultsProvider (#32551)
dnhatn added a commit that referenced this issue Aug 13, 2018
@dnhatn
AwaitsFix case-functions.sql-spec
cba7fce 
Relates #32589
@dnhatn
Copy link
Member

dnhatn commented Aug 13, 2018

@astefan I am reopening this because it still fails with Locale az-Cyrl-AZ. I think we need to add to az-Cyrl-AZ to the ignored locale list.

CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=java11,nodes=virtual&&linux/236/console

@dnhatn dnhatn reopened this Aug 13, 2018
dnhatn added a commit that referenced this issue Aug 13, 2018
@dnhatn
AwaitsFix case-functions.sql-spec
026be66 
Relates #32589
@astefan
Copy link
Contributor

astefan commented Aug 14, 2018

@dnhatn thanks. I'm looking into it.

@astefan astefan mentioned this issue Aug 16, 2018
Merged
@astefan astefan closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astefan astefan

Labels
:Analytics/SQL SQL querying >bug >test-failure Triaged test failures from CI v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dakrone @colings86 @astefan @dnhatn @elasticmachine