Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ScriptedMetricIT testInitMapWithParams fails #32959

Closed
jkakavas opened this issue Aug 17, 2018 · 2 comments · Fixed by #32968
Closed

[CI] ScriptedMetricIT testInitMapWithParams fails #32959

jkakavas opened this issue Aug 17, 2018 · 2 comments · Fixed by #32968
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI

Comments

@jkakavas
Copy link
Member

Failed in master twice : https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+intake/2549/console

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+intake/2548/console

./gradlew :server:integTest \
  -Dtests.seed=D714A8F18E960CA2 \
  -Dtests.class=org.elasticsearch.search.aggregations.metrics.ScriptedMetricIT \
  -Dtests.method="testInitMapWithParams" \
  -Dtests.security.manager=true \
  -Dtests.locale=es-UY \
  -Dtests.timezone=America/Puerto_Rico \
  -Dcompiler.java=10 \
  -Druntime.java=8

Reproduces locally also.

It looks like it fails because of the changes merged today in #31597
@jkakavas jkakavas added :Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI labels Aug 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@rationull
Copy link
Contributor

rationull commented Aug 17, 2018 •
edited
Loading

This is my mistake -- an oversight in my changes to ScriptedMetricIT. There's a hole where a shard with 0 documents in it will cause a failure because the assertions rely on a side effect from the map script. This is a test problem only; not a server problem. I will submit a PR with a fix.

rationull added a commit to rationull/elasticsearch that referenced this issue Aug 17, 2018
@rationull
Protect ScriptedMetricIT test cases against failures on 0-doc shards (e…
0b4c69a 
…lastic#32959)

Randomized test conditions that cause some shards to have no docs on them
failed due to test asserts that relied on a lazy initialization side effect
from the map script. After this fix:

- Test cases with the relevant init script are protected
- Test cases with the relevant combine or reduce scripts were already
  protected, because the combine and reduce scripts safely handle this case.
@rationull rationull mentioned this issue Aug 18, 2018
Merged
colings86 pushed a commit that referenced this issue Aug 20, 2018
@rationull @colings86
Protect ScriptedMetricIT test cases against failures on 0-doc shards (#…
676091a 
…32959) (#32968)

Randomized test conditions that cause some shards to have no docs on them
failed due to test asserts that relied on a lazy initialization side effect
from the map script. After this fix:

- Test cases with the relevant init script are protected
- Test cases with the relevant combine or reduce scripts were already
  protected, because the combine and reduce scripts safely handle this case.
colings86 pushed a commit that referenced this issue Aug 20, 2018
@rationull @colings86
Protect ScriptedMetricIT test cases against failures on 0-doc shards (#…
b09eac7 
…32959) (#32968)

Randomized test conditions that cause some shards to have no docs on them
failed due to test asserts that relied on a lazy initialization side effect
from the map script. After this fix:

- Test cases with the relevant init script are protected
- Test cases with the relevant combine or reduce scripts were already
  protected, because the combine and reduce scripts safely handle this case.
jasontedor added a commit that referenced this issue Aug 20, 2018
@jasontedor
Merge branch 'master' into ccr
853eb1c 
* master:
  Generalize remote license checker (#32971)
  Trim translog when safe commit advanced (#32967)
  Fix an inaccuracy in the dynamic templates documentation. (#32890)
  Logging: Use settings when building daemon threads (#32751)
  All Translog inner closes should happen after tragedy exception is set (#32674)
  HLREST: AwaitsFix ML Test
  Pass DiscoveryNode to initiateChannel (#32958)
  Add mzn and dz to unsupported locales (#32957)
  Use settings from the context in BootstrapChecks (#32908)
  Update docs for node specifications (#30468)
  HLRC: Forbid all Elasticsearch logging infra (#32784)
  Only configure publishing if it's applied externally (#32351)
  Fixes libs:dissect when in eclipse
  Protect ScriptedMetricIT test cases against failures on 0-doc shards (#32959) (#32968)
  [Kerberos] Add documentation for Kerberos realm (#32662)
  Watcher: Properly find next valid date in cron expressions (#32734)
  Fix some small issues in the getting started docs (#30346)
  Set forbidden APIs target compatibility to compiler java version   (#32935)
  Move connection listener to ConnectionManager (#32956)
jasontedor added a commit to jasontedor/elasticsearch that referenced this issue Aug 21, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into allowed-index-stor…
be8ce3b 
…e-types

* elastic/master: (89 commits)
  Fix assertion in AbstractSimpleTransportTestCase (elastic#32991)
  [DOC] Splits role mapping APIs into separate pages (elastic#32797)
  HLRC: ML Close Job (elastic#32943)
  Generalize remote license checker (elastic#32971)
  Trim translog when safe commit advanced (elastic#32967)
  Fix an inaccuracy in the dynamic templates documentation. (elastic#32890)
  Logging: Use settings when building daemon threads (elastic#32751)
  All Translog inner closes should happen after tragedy exception is set (elastic#32674)
  HLREST: AwaitsFix ML Test
  Pass DiscoveryNode to initiateChannel (elastic#32958)
  Add mzn and dz to unsupported locales (elastic#32957)
  Use settings from the context in BootstrapChecks (elastic#32908)
  Update docs for node specifications (elastic#30468)
  HLRC: Forbid all Elasticsearch logging infra (elastic#32784)
  Only configure publishing if it's applied externally (elastic#32351)
  Fixes libs:dissect when in eclipse
  Protect ScriptedMetricIT test cases against failures on 0-doc shards (elastic#32959) (elastic#32968)
  [Kerberos] Add documentation for Kerberos realm (elastic#32662)
  Watcher: Properly find next valid date in cron expressions (elastic#32734)
  Fix some small issues in the getting started docs (elastic#30346)
  ...
jasontedor pushed a commit that referenced this issue Aug 21, 2018
@rationull @jasontedor
Protect ScriptedMetricIT test cases against failures on 0-doc shards (#…
aecc997 
…32959) (#32968)

Randomized test conditions that cause some shards to have no docs on them
failed due to test asserts that relied on a lazy initialization side effect
from the map script. After this fix:

- Test cases with the relevant init script are protected
- Test cases with the relevant combine or reduce scripts were already
  protected, because the combine and reduce scripts safely handle this case.
jasontedor added a commit to jasontedor/elasticsearch that referenced this issue Aug 24, 2018
@jasontedor
Merge branch '6.x' into ccr-6.x
d894679 
* commit '9088d811ce9cff922e6ef1befbeb0f1e0c27016a': (23 commits)
  Generalize remote license checker (elastic#32971)
  Trim translog when safe commit advanced (elastic#32967)
  Fix an inaccuracy in the dynamic templates documentation. (elastic#32890)
  HLREST: AwaitsFix ML Test
  Make Geo Context Mapping Parsing More Strict (elastic#32862)
  Add mzn and dz to unsupported locales (elastic#32957)
  Use settings from the context in BootstrapChecks (elastic#32908)
  Update docs for node specifications (elastic#30468)
  HLRC: Forbid all Elasticsearch logging infra (elastic#32784)
  Fix use of deprecated apis
  Only configure publishing if it's applied externally (elastic#32351)
  Protect ScriptedMetricIT test cases against failures on 0-doc shards (elastic#32959) (elastic#32968)
  Scripted metric aggregations: add deprecation warning and system (elastic#32944)
  Watcher: Properly find next valid date in cron expressions (elastic#32734)
  Fix some small issues in the getting started docs (elastic#30346)
  Set forbidden APIs target compatibility to compiler java version   (elastic#32935)
  [TEST] Add "ne" as an unsupported SimpleKdc locale (elastic#32700)
  MINOR: Remove `IndexTemplateFilter` (elastic#32841) (elastic#32974)
  INGEST: Create Index Before Pipeline Execute (elastic#32786) (elastic#32975)
  NETWORKING: Make RemoteClusterConn. Lazy Resolve DNS (elastic#32764) (elastic#32976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
3 participants
@rationull @jkakavas @elasticmachine