Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletionFieldMapper should ignore null values #33200

Closed
jimczi opened this issue Aug 28, 2018 · 3 comments
Closed

CompletionFieldMapper should ignore null values #33200

jimczi opened this issue Aug 28, 2018 · 3 comments
Labels
>bug good first issue low hanging fruit :Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@jimczi
Copy link
Contributor

jimczi commented Aug 28, 2018

Today the completion field throws an exception if the json input is an explicit null value.
The other field types just ignore these inputs so I don't see a reason why we should do differently here.
This would also allow unsetting suggestions in the partial update case.
@jimczi jimczi added >bug good first issue low hanging fruit help wanted adoptme :Search Relevance/Suggesters "Did you mean" and suggestions as you type labels Aug 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi jimczi mentioned this issue Aug 28, 2018
Merged
@tony-dillon
Copy link
Contributor

tony-dillon commented Aug 28, 2018 •
edited
Loading

@jimczi I think I'm going to have a go at fixing this, can you please assign this ticket to me?

@jimczi
Copy link
Contributor Author

jimczi commented Aug 28, 2018

Thanks @tony-dillon , we cannot assign issue to users but feel free to work on it. I'll remove the adoptme label.

@jimczi jimczi removed the help wanted adoptme label Aug 28, 2018
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 28, 2018
@tony-dillon
[Issue elastic#33200] null completion values should not throw IAE and…
1c5da09 
… be added to ignored fields
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] fixed test
9d96f19
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] updated test to use Token.NULL_VALUE
681b868
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] stopped adding null fields to ignored field lis…
47513b9 
…t. restored else if. updated test to assert ignored fields is null
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] fixed error where wrong document was being asse…
113245b 
…rted on
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] set correct null field value on test document
94790b1
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] set nullField on correct document
576dc7b
tony-dillon added a commit to tony-dillon/elasticsearch that referenced this issue Aug 30, 2018
@tony-dillon
[Issue elastic#33200] remove unused use statement
563de3f
@jimczi jimczi closed this as completed in a9d2b1d Sep 3, 2018
jimczi pushed a commit that referenced this issue Sep 3, 2018
@tony-dillon @jimczi
Null completion field should not throw IAE (#33268)
bc37003 
Ignore null value on the completion field

Closes #33200
jimczi pushed a commit that referenced this issue Sep 3, 2018
@tony-dillon @jimczi
Null completion field should not throw IAE (#33268)
021e352 
Ignore null value on the completion field

Closes #33200
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug good first issue low hanging fruit :Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tony-dillon @javanna @elasticmachine @jimczi