Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field alias updates are not reflected in percolator queries. #37212

Open
jtibshirani opened this issue Jan 8, 2019 · 4 comments
Open

Field alias updates are not reflected in percolator queries. #37212

jtibshirani opened this issue Jan 8, 2019 · 4 comments
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Jan 8, 2019 •
edited
Loading

We currently allow the path of a field alias to be changed through a mapping update. This interacts poorly with percolator queries, as seen in the following gist where changing the path of an alias causes a percolator query to no longer match as expected: https://gist.github.com/jtibshirani/c86b5533b1b4d3ab83fb44280e4817b9. The issue is especially tricky because updating a field alias can update the actual field type (say from keyword to long), which may affect how percolator indexes the query.

This bug raises a larger question: do we want to allow the path of a field alias to change, as is currently implemented?

Relates to #36418, which discusses the possibility of deleting field aliases.
@jtibshirani jtibshirani added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types team-discuss labels Jan 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jtibshirani jtibshirani mentioned this issue Jan 8, 2019
Closed
@jpountz
Copy link
Contributor

jpountz commented Jan 14, 2019

We discussed this issue in the search meeting and agreed to either:

  • find a way to disallow updates on aliases when percolator fields are in use or disallow using alias field in percolator queries if this can be done in a way that is easy to maintain, or
  • document this limitation in the percolator docs otherwise.

@jpountz jpountz added help wanted adoptme and removed team-discuss labels Jan 14, 2019
jtibshirani added a commit to jtibshirani/elasticsearch that referenced this issue Mar 14, 2019
@jtibshirani
Document the limitation around field aliases and percolator.
b4f9b22 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to elastic#37212.
@jtibshirani jtibshirani mentioned this issue Mar 14, 2019
Merged
jtibshirani added a commit that referenced this issue Mar 15, 2019
@jtibshirani
Document the limitation around field aliases and percolator. (#40073)
91181e6 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to #37212.
jtibshirani added a commit that referenced this issue Mar 15, 2019
@jtibshirani
Document the limitation around field aliases and percolator. (#40073)
6ffa8a0 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to #37212.
jtibshirani added a commit that referenced this issue Mar 15, 2019
@jtibshirani
Document the limitation around field aliases and percolator. (#40073)
4d3839b 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to #37212.
jtibshirani added a commit that referenced this issue Mar 15, 2019
@jtibshirani
Document the limitation around field aliases and percolator. (#40073)
a913828 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to #37212.
jtibshirani added a commit that referenced this issue Mar 15, 2019
@jtibshirani
Document the limitation around field aliases and percolator. (#40073)
af4bb0b 
Currently if a field alias is updated, any percolator queries that contain the
alias will still refer to its old target. This PR documents the issue while we
look into addressing it.

Relates to #37212.
@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@jtibshirani jtibshirani mentioned this issue Mar 29, 2021
Closed
@jtibshirani jtibshirani removed the help wanted adoptme label May 5, 2021
@javanna javanna added the priority:normal A label for assessing bug priority to be used by ES engineers label Jun 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rjernst @jpountz @javanna @jtibshirani @elasticmachine @elasticsearchmachine