Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing date ingest processor to Java time also changes date index naming #37935

Closed
droberts195 opened this issue Jan 28, 2019 · 4 comments
Closed
Labels
:Core/Infra/Core Core issues without another label team-discuss

Comments

@droberts195
Copy link
Contributor

droberts195 commented Jan 28, 2019

The date ingest processor was changed to allow Java time formats prefixed with 8 in #37407, but the default time format is still Joda after this change. To match what has been done for mappings in version 7 the default time format for ingest should be Java time, so that formats with and without an 8 prefix are treated identically.

I opened #37934 to make this change (as I want to test that the ML file structure finder works with it in v7). However, while making this change I found that changing the default for date processing in ingest also affects index naming with the date index name processor. After a brief chat with @spinscale I am raising this issue for further discussion of whether extra measures need to be taken regarding index naming by the date index name processor through the 6.x -> 7.x upgrade. I can imagine it might cause problems for Beats?

Relates #27330

@droberts195 droberts195 added :Core/Infra/Core Core issues without another label team-discuss labels Jan 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@droberts195
Copy link
Contributor Author

/cc @elastic/beats

@jsoriano
Copy link
Member

I have created an issue in Beats to track tasks around this elastic/beats#10433

@droberts195
Copy link
Contributor Author

We discussed this in the ES core infra meeting and it seems that there is no particular problem with the date index name processor, so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label team-discuss
Projects
None yet
Development

No branches or pull requests

3 participants