Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject port ranges in discovery.seed_hosts #40786

Closed
DaveCTurner opened this issue Apr 3, 2019 · 4 comments · Fixed by #41404
Closed

Reject port ranges in discovery.seed_hosts #40786

DaveCTurner opened this issue Apr 3, 2019 · 4 comments · Fixed by #41404
Labels
>bug :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. help wanted adoptme v7.2.0

Comments

@DaveCTurner
Copy link
Contributor

Today Elasticsearch accepts, but silently ignores, port ranges in the discovery.seed_hosts setting:

discovery.seed_hosts: 10.1.2.3:9300-9400

Silently ignoring part of a setting is trappy and we should instead reject this setting if it contains port ranges like this.
@DaveCTurner DaveCTurner added >bug v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Apr 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@DaveCTurner DaveCTurner mentioned this issue Apr 3, 2019
Closed
@DaveCTurner DaveCTurner added the help wanted adoptme label Apr 3, 2019
@Hohol
Copy link
Contributor

Hohol commented Apr 9, 2019

I'd like to work on this. Could you assign me please?

@DaveCTurner
Copy link
Contributor Author

Hi @Hohol, I can't assign issues outside of the Elastic organisation, but you're welcome to work on this.

@polyfractal polyfractal added v7.2.0 and removed v7.0.0 labels Apr 9, 2019
@Hohol Hohol mentioned this issue Apr 22, 2019
Merged
@Hohol
Copy link
Contributor

Hohol commented Apr 22, 2019

@DaveCTurner I've made a PR #41404

DaveCTurner pushed a commit that referenced this issue May 7, 2019
@Hohol @DaveCTurner
Reject port ranges in discovery.seed_hosts (#41404)
e6019b4 
Today Elasticsearch accepts, but silently ignores, port ranges in the
`discovery.seed_hosts` setting:

```
discovery.seed_hosts: 10.1.2.3:9300-9400
```

Silently ignoring part of a setting like this is trappy. With this change we
reject seed host addresses of this form.

Closes #40786
DaveCTurner pushed a commit to DaveCTurner/elasticsearch that referenced this issue May 7, 2019
@Hohol @DaveCTurner
Reject port ranges in discovery.seed_hosts
313a85e 
Today Elasticsearch accepts, but silently ignores, port ranges in the
`discovery.seed_hosts` setting:

```
discovery.seed_hosts: 10.1.2.3:9300-9400
```

Silently ignoring part of a setting like this is trappy. With this change we
reject seed host addresses of this form.

Closes elastic#40786
Backport of elastic#41404
@DaveCTurner DaveCTurner mentioned this issue May 7, 2019
Merged
DaveCTurner added a commit that referenced this issue May 8, 2019
@DaveCTurner
Reject port ranges in discovery.seed_hosts (#41905)
4c909e9 
Today Elasticsearch accepts, but silently ignores, port ranges in the
`discovery.seed_hosts` setting:

```
discovery.seed_hosts: 10.1.2.3:9300-9400
```

Silently ignoring part of a setting like this is trappy. With this change we
reject seed host addresses of this form.

Closes #40786
Backport of #41404
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this issue May 27, 2019
@Hohol
Reject port ranges in discovery.seed_hosts (elastic#41404)
aec7498 
Today Elasticsearch accepts, but silently ignores, port ranges in the
`discovery.seed_hosts` setting:

```
discovery.seed_hosts: 10.1.2.3:9300-9400
```

Silently ignoring part of a setting like this is trappy. With this change we
reject seed host addresses of this form.

Closes elastic#40786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. help wanted adoptme v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject port ranges in discovery.seed_hosts
4 participants
@polyfractal @Hohol @DaveCTurner @elasticmachine