Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support _FILE suffix in docker images #43603

Closed
rjernst opened this issue Jun 25, 2019 · 1 comment · Fixed by #47573
Closed

[Feature Request] Support _FILE suffix in docker images #43603

rjernst opened this issue Jun 25, 2019 · 1 comment · Fixed by #47573
Assignees
@pugnascotia
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team

Comments

@rjernst
Copy link
Member

rjernst commented Jun 25, 2019

NOTE: This was originally filed by @nikeee in elastic/elasticsearch-docker#183.

There is a convention on official docker images that environment variables that end in _FILE are read as a file and then assigned to a variable without the _FILE suffix. For example, setting the environment variable ELASTIC_PASSWORD_FILE to /run/secrets/secret-password will read the file /run/secrets/secret-password and assign its contents to the environment variable ELASTIC_PASSWORD. This is especially handy when using Docker secrets.

Related issue on Grafana: grafana/grafana-docker#166
Thread on forums: https://discuss.elastic.co/t/feature-request-support-file-suffix-in-docker-images/140107
@rjernst rjernst mentioned this issue Jun 25, 2019
Closed
@tlrx tlrx added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Jun 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pugnascotia pugnascotia self-assigned this Oct 2, 2019
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this issue Oct 2, 2019
@pugnascotia
Support ELASTIC_PASSWORD_FILE in Docker entrypoint
05a0133 
Closes elastic#43603. Allow a password to be specifed in an ES Docker container
by specifying a file path in the ELASTIC_PASSWORD_FILE environment
variable.
@pugnascotia pugnascotia mentioned this issue Oct 4, 2019
Merged
pugnascotia added a commit that referenced this issue Nov 12, 2019
@pugnascotia
Support _FILE suffixed env vars in Docker entrypoint (#47573)
2a4e101 
Closes #43603. Allow environment variables to be passed to ES in a Docker
container via a file, by setting an environment variable with the `_FILE`
suffix that points to the file with the intended value of the env var.
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this issue Nov 15, 2019
@pugnascotia
Support _FILE suffixed env vars in Docker entrypoint
f74b89a 
Backport of elastic#47573.

Closes elastic#43603. Allow environment variables to be passed to ES in a Docker
container via a file, by setting an environment variable with the `_FILE`
suffix that points to the file with the intended value of the env var.
@pugnascotia pugnascotia mentioned this issue Nov 15, 2019
Merged
pugnascotia added a commit that referenced this issue Nov 18, 2019
@pugnascotia
Support _FILE suffixed env vars in Docker entrypoint (#49182)
e84e211 
Backport of #47573.

Closes #43603. Allow environment variables to be passed to ES in a Docker
container via a file, by setting an environment variable with the `_FILE`
suffix that points to the file with the intended value of the env var.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pugnascotia pugnascotia

Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support _FILE suffixed env vars in Docker entrypoint pugnascotia/elasticsearch
5 participants
@rjernst @tlrx @mark-vieira @pugnascotia @elasticmachine