Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: change date_histogram to stop using deprecated "interval" #43922

Closed
astefan opened this issue Jul 3, 2019 · 1 comment · Fixed by #45501
Closed

SQL: change date_histogram to stop using deprecated "interval" #43922

astefan opened this issue Jul 3, 2019 · 1 comment · Fixed by #45501

Comments

@astefan
Copy link
Contributor

astefan commented Jul 3, 2019

Following #33727 the interval has been considered deprecated in favor of calendar_interval and fixed_interval. For 8.x and 7.2+, we should make the change in SQL as well.

This, also, brings another interesting side effect: lack of tests that check the response headers of sql requests.

warning →299 Elasticsearch-8.0.0-SNAPSHOT-e1e3c61 "[interval] on [date_histogram] is deprecated, use [fixed_interval] or [calendar_interval] in the future."

The deprecation message is being transmitted as an http header and we should check the expected, if not already done, list of incoming headers in our tests.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants