Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: remove deprecated use of "interval" from date_histogram usage #45501

Merged
merged 2 commits into from
Aug 16, 2019
Merged

SQL: remove deprecated use of "interval" from date_histogram usage #45501

merged 2 commits into from
Aug 16, 2019

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Aug 13, 2019

The introduction of #33727 also deprecated the use of "interval" generic method for date_histogram aggregation. This PR remove the use of interval() in favor of fixedInterval.

Fixes #43922.

@astefan astefan requested a review from costin August 13, 2019 11:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@astefan
Copy link
Contributor Author

astefan commented Aug 13, 2019

@elasticmachine run elasticsearch-ci/1

costin
costin approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin
Copy link
Member

costin commented Aug 14, 2019

It's worth investigating whether backporting to 7.2.2 is still needed

@astefan astefan merged commit 3fef651 into elastic:master Aug 16, 2019
@astefan astefan deleted the 43922_fix branch August 16, 2019 12:01
astefan added a commit that referenced this pull request Aug 16, 2019
@astefan
Remove deprecated use of "interval" method, in favor of "fixedInterva…
30a0711 
…l". (#45501)

(cherry picked from commit 3fef651)
astefan added a commit that referenced this pull request Aug 16, 2019
@astefan
Remove deprecated use of "interval" method, in favor of "fixedInterva…
143345d 
…l". (#45501)

(cherry picked from commit 3fef651)
astefan added a commit that referenced this pull request Aug 16, 2019
@astefan
Remove deprecated use of "interval" method, in favor of "fixedInterva…
5e90c3b 
…l". (#45501)

(cherry picked from commit 3fef651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v7.2.2 v7.3.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: change date_histogram to stop using deprecated "interval"
4 participants
@astefan @elasticmachine @costin @jakelandis