Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove the ability to move datafeeds between jobs #44616

Closed
droberts195 opened this issue Jul 19, 2019 · 1 comment · Fixed by #44752
Closed

[ML] Remove the ability to move datafeeds between jobs #44616

droberts195 opened this issue Jul 19, 2019 · 1 comment · Fixed by #44752
Labels

Comments

@droberts195
Copy link
Contributor

After #44615 has been implemented the ability to move datafeeds between jobs should be removed from the master branch. As anomaly detection jobs and datafeeds have become more closely coupled this is undesirable and adds complexity.

The update datafeed REST endpoint should be changed to report an error if it receives a request containing job_id. If an 8.x node receives a request over wire transport that contains job_id then it should refuse to process the request and return an error response.

Removal of the ability to move a datafeed to a different job should then open up the possibility to simplify other code. For example there will be no need for 8.x to consider deleting datafeed timing stats when moving a datafeed to a different job. There may be other places where the code can be simplified too.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants