Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeystoreManagementTests work in the docker case #49469

Closed
williamrandolph opened this issue Nov 21, 2019 · 5 comments
Closed

Make KeystoreManagementTests work in the docker case #49469

williamrandolph opened this issue Nov 21, 2019 · 5 comments
Assignees
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests

Comments

@williamrandolph
Copy link
Contributor

While I was working on #32691, we added some Docker packaging tests. Right now, some of the keystore tests are failing on the distroTest.default-docker task, e.g. :qa:os:centos-6:distroTest.default-docker.

Ideally, the keystore management tests can be flexible enough to run even in the docker case. If not, the tests should be fixed so that they don't run for that docker testing task.

Relates #32691

@williamrandolph williamrandolph added >test Issues or PRs that are addressing/adding tests :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Nov 21, 2019
@williamrandolph williamrandolph self-assigned this Nov 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@pugnascotia
Copy link
Contributor

@williamrandolph let me know if I can help here.

@williamrandolph
Copy link
Contributor Author

@pugnascotia OK, I'm looping back around to this now.

Right now we have a PackagingTestCase class that all of the more specific test classes inherit from. Almost all of those classes either exclude Docker explicitly or select a specific packaging type other than Docker. The one exception? DockerTests, which extends PackagingTestCase but modifies the setup before each test by setting the Shell object to a new DockerShell and setting the installation object with runContainer.

If I want to make the KeystoreManagementTest class run correctly for Docker, it seems like I would have to push that Docker-specific shell/installation setup into the PackagingTestCase class. Is that something you tried doing while you were writing these test cases? Do you think there's any reason that approach wouldn't work in principle?

@pugnascotia
Copy link
Contributor

I didn't try that approach, but it certainly sounds reasonable. If you run into any issues, let me know and we'll figure it out.

@williamrandolph
Copy link
Contributor Author

Closed by #50610

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

4 participants