Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntervalQueryBuilderTests.testCacheability #49821

Closed
pugnascotia opened this issue Dec 4, 2019 · 2 comments · Fixed by #49824
Closed

IntervalQueryBuilderTests.testCacheability #49821

pugnascotia opened this issue Dec 4, 2019 · 2 comments · Fixed by #49824
Assignees
@romseygeek
Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v7.6.0

Comments

@pugnascotia
Copy link
Contributor

pugnascotia commented Dec 4, 2019 •
edited
Loading

Test failed with:

java.lang.AssertionError: query should be cacheable: {
      "intervals" : {
        "mapped_string" : {
          "match" : {
            "query" : "ߌߙ߂߇ߵߚߕߢߊߖߛ߷ߓ߿ߊߐ߬ߋߠa \uD841\uDDDC\uD848\uDC72a",
            "max_gaps" : 1,
            "ordered" : true,
            "analyzer" : "keyword",
            "filter" : {
              "script" : {
                "source" : "1",
                "lang" : "mockscript"
              }
            }
          },
          "boost" : 1.0
        }
      }
    }

Reproducible on 7.x with:

./gradlew ':server:test' --tests \
    "org.elasticsearch.index.query.IntervalQueryBuilderTests.testCacheability" \
    -Dtests.seed=F17366F2B487C861 -Dtests.security.manager=true \
    -Dtests.locale=ar-QA -Dtests.timezone=SystemV/YST9YDT -Dcompiler.java=12 \
    -Druntime.java=8

Didn't reproduce on master (with the runtime set to 11).

Build scan
@pugnascotia pugnascotia added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v7.6.0 labels Dec 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@romseygeek romseygeek self-assigned this Dec 4, 2019
@romseygeek
Copy link
Contributor

Interval filters that use scripts are not cacheable, so this is a test bug. I'll open a PR.

@romseygeek romseygeek mentioned this issue Dec 4, 2019
Merged
romseygeek added a commit that referenced this issue Dec 4, 2019
@romseygeek
[CI] Interval queries cannot be cached if they use scripts (#49824)
f38ce06 
#49793 added test coverage for interval queries that contain script filters, but did
not adjust testCacheability(), which how fails occasionally when given a random
interval source containing a script. This commit overrides testCacheability() to
explicitly sources with and without script filters.

Fixes #49821
romseygeek added a commit that referenced this issue Dec 4, 2019
@romseygeek
[CI] Interval queries cannot be cached if they use scripts (#49824)
aa443c6 
not adjust testCacheability(), which how fails occasionally when given a random
interval source containing a script. This commit overrides testCacheability() to
explicitly sources with and without script filters.

Fixes #49821
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@romseygeek @SivagurunathanV
[CI] Interval queries cannot be cached if they use scripts (elastic#4…
b1f4a85 
…9824)

elastic#49793 added test coverage for interval queries that contain script filters, but did
not adjust testCacheability(), which how fails occasionally when given a random
interval source containing a script. This commit overrides testCacheability() to
explicitly sources with and without script filters.

Fixes elastic#49821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romseygeek romseygeek

Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Interval queries cannot be cached if they use scripts romseygeek/elasticsearch
3 participants
@romseygeek @pugnascotia @elasticmachine