Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlighting and autocomplete for painless to kibana via Monaco #49879

Closed
stu-elastic opened this issue Dec 5, 2019 · 4 comments
Closed

Add highlighting and autocomplete for painless to kibana via Monaco #49879

stu-elastic opened this issue Dec 5, 2019 · 4 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

Monaco is a in-browser implementation of VS Code that was recently added to Kibana.

We should integrate with Monaco to make writing painless scripts easier for users. This includes highlighting and autocomplete.
@stu-elastic stu-elastic self-assigned this Dec 5, 2019
@stu-elastic
Copy link
Contributor Author

Migrated from: #31009

@stu-elastic stu-elastic added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Dec 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@stu-elastic stu-elastic removed their assignment Dec 5, 2019
@stu-elastic
Copy link
Contributor Author

  • Setup vscode/monaco and register a LSP server for painless
  • See request frequency for LSP

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
stu-elastic added a commit that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: Whitelist API spec gradle task (#66050)
2aa2224 
Adds `generateContextApiSpec` gradle task that generates whitelist api
specs under `modules/lang-painless/src/main/generated/whitelist-json`.

The common classes are in `painless-common.json`, the specialized classes
per context are in `painless-$context.json`.

eg. `painless-aggs.json` has the specialization for the aggs contexts

Refs: #49879
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: Whitelist API spec gradle task (elastic#66050)
866a346 
Adds `generateContextApiSpec` gradle task that generates whitelist api
specs under `modules/lang-painless/src/main/generated/whitelist-json`.

The common classes are in `painless-common.json`, the specialized classes
per context are in `painless-$context.json`.

eg. `painless-aggs.json` has the specialization for the aggs contexts

Refs: elastic#49879
@stu-elastic stu-elastic mentioned this issue Dec 9, 2020
Merged
stu-elastic added a commit that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: Whitelist API spec gradle task (#66050) (#66115)
5b8bac3 
Adds `generateContextApiSpec` gradle task that generates whitelist api
specs under `modules/lang-painless/src/main/generated/whitelist-json`.

The common classes are in `painless-common.json`, the specialized classes
per context are in `painless-$context.json`.

eg. `painless-aggs.json` has the specialization for the aggs contexts

Refs: #49879
 Backport: 2aa2224
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: whitelist api spec, refs elastic#49879
6753977
stu-elastic added a commit that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: whitelist api spec, refs #49879 (#66120)
0be70fd
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: whitelist api spec, refs elastic#49879 (elastic#66120)
7f52fc2
@stu-elastic stu-elastic removed the needs:triage Requires assignment of a team area label label Dec 9, 2020
stu-elastic added a commit that referenced this issue Dec 9, 2020
@stu-elastic
Scripting: whitelist api spec, refs #49879 (#66120) (#66127)
5772a78 
Adds the whitelist API for each context, along with the common whitelist.

Used by monaco for autocomplete.

Generated by `generateContextApiSpec`

Backport: 0be70fd
@stu-elastic stu-elastic mentioned this issue Mar 23, 2021
Closed
@rjernst
Copy link
Member

rjernst commented May 25, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@rjernst rjernst closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjernst @elasticmachine @stu-elastic