-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and remove camel-case nGram and edgeNGram tokenizers #50561
Labels
:Search Relevance/Analysis
How text is split into tokens
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v7.6.0
v8.0.0-alpha1
Comments
Pinging @elastic/es-search (:Search/Analysis) |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this issue
Jan 10, 2020
We already deprecated and removed the camel-case versions of the nGram and edgeNGram filters a while ago and we should do the same with the nGram and edgeNGram tokenizers. This PR deprecates the use of these names in favour of ngram and edge_ngram in 7 and disallows usage in new indices starting with 8. The deprecation part will be backported to 7.6. Closes elastic#50561
cbuescher
pushed a commit
that referenced
this issue
Jan 14, 2020
We already deprecated and removed the camel-case versions of the nGram and edgeNGram filters a while ago and we should do the same with the nGram and edgeNGram tokenizers. This PR deprecates the use of these names in favour of ngram and edge_ngram in 7 and disallows usage in new indices starting with 8. Closes #50561
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this issue
Jan 14, 2020
…ic#50862) We already deprecated and removed the camel-case versions of the nGram and edgeNGram filters a while ago and we should do the same with the nGram and edgeNGram tokenizers. This PR deprecates the use of these names in favour of ngram and edge_ngram in 7. Usage will be disallowed on new indices starting with 8 then. Closes elastic#50561
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this issue
Jan 23, 2020
…ic#50862) We already deprecated and removed the camel-case versions of the nGram and edgeNGram filters a while ago and we should do the same with the nGram and edgeNGram tokenizers. This PR deprecates the use of these names in favour of ngram and edge_ngram in 7 and disallows usage in new indices starting with 8. Closes elastic#50561
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search Relevance/Analysis
How text is split into tokens
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v7.6.0
v8.0.0-alpha1
We deprecated and removed the camel-case versions of the
nGram
andedgeNGram
filtersa while ago (deprecation in 6, removal ongoing see #50376). I think we
should do the same with the
nGram
andedgeNGram
tokenizers, deprecating the use of these naming variantsin favour of
ngram
andedge_ngram
in 7, preventing newly created indices to use them starting with 8 and removalin a future version where there can be no indices using them any longer.
The text was updated successfully, but these errors were encountered: