Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET _cat/shards?local and GET _cat/indices?local are not completely local #60718

Closed
DaveCTurner opened this issue Aug 5, 2020 · 6 comments
Closed

GET _cat/shards?local and GET _cat/indices?local are not completely local #60718

DaveCTurner opened this issue Aug 5, 2020 · 6 comments
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat Team:Data Management Meta label for data/management team

Comments

@DaveCTurner
Copy link
Contributor

DaveCTurner commented Aug 5, 2020 •
edited
Loading

The cat shards and cat indices APIs perform a ClusterStateAction then a IndicesStatsAction. They accept the ?local parameter and passes this to the ClusterStateAction but this parameter has no effect on the IndicesStatsAction. This is surprising, because GET _cat/shards?local and GET _cat/indices?local look like they might be completely local calls but in fact they still depend on every data node in the cluster.

I think the ?local parameter does not make sense on these APIs and we should remove it.

Relates #50088 which is the same issue for GET _cat/nodes.
@DaveCTurner DaveCTurner added >bug :Data Management/CAT APIs Text APIs behind /_cat labels Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Aug 5, 2020
@boicehuang
Copy link
Contributor

Do _cat/indices?local have the same behavior?

@DaveCTurner
Copy link
Contributor Author

Yes, GET _cat/indices?local is also nonlocal as it also uses a cluster-wide indices stats request.

@DaveCTurner DaveCTurner changed the title GET _cat/shards?local is not completely local GET _cat/shards?local and GET _cat/indices?local are not completely local Aug 21, 2020
@boicehuang
Copy link
Contributor

boicehuang commented Aug 21, 2020 •
edited
Loading

May I work on this one? Any hints are appreciated.

@DaveCTurner
Copy link
Contributor Author

Sure, go ahead. See #50088 for a good example of deprecating and removing a REST parameter like this.

This was referenced Sep 10, 2020
Merged
Merged
This was referenced Oct 29, 2020
Merged
Merged
@danhermann
Copy link
Contributor

The local parameters have been deprecated in 7.x and removed for 8.x.

@stevejgordon stevejgordon mentioned this issue Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boicehuang @DaveCTurner @elasticmachine @danhermann