Query parse failures not being returned as server errors

[clintongormley]

Hiya

If the search query doesn't parse correctly, the server should return a server error. Currently, it returns the errors in the response, but the status code is 200:

curl -XGET 'http://192.168.5.100:9200/_all/_search'  -d '
{
   "query" : {}
}
'
# {
#    "hits" : {
#       "hits" : [],
#       "total" : 0
#    },
#    "_shards" : {
#       "failures" : [
#          {
#             "index" : "ia_object",
#             "reason" : "SearchParseException[[ia_object][3]: quer
# >             y[null],from[-1],size[-1]: Parse Failure [Failed to
# >  parse [{\n   \"query\" : {}\n}\n]]]; nested: QueryParsingExcep
# > tion[[ia_object] No json query parser registered for [query]]; 
# > ",
#             "shardId" : 3
#          },
#          {
#             "index" : "ia_object",
#             "reason" : "SearchParseException[[ia_object][1]: quer
# >             y[null],from[-1],size[-1]: Parse Failure [Failed to
# >  parse [{\n   \"query\" : {}\n}\n]]]; nested: QueryParsingExcep
# > tion[[ia_object] No json query parser registered for [query]]; 
# > ",
#             "shardId" : 1
#          },
#          {
#             "index" : "ia_object",
#             "reason" : "SearchParseException[[ia_object][2]: quer
# >             y[null],from[-1],size[-1]: Parse Failure [Failed to
# >  parse [{\n   \"query\" : {}\n}\n]]]; nested: QueryParsingExcep
# > tion[[ia_object] No json query parser registered for [query]]; 
# > ",
#             "shardId" : 2
#          },
#          {
#             "reason" : "Unknown"
#          },
#          {
#             "reason" : "Unknown"
#          }
#       ],
#       "failed" : 5,
#       "successful" : 0,
#       "total" : 5
#    }
# }

[clintongormley]

Fixed