Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Mute all tsdb tests in mixedClusterTests, for versions 8.7 - 8.10 #100805

Merged
merged 18 commits into from
Oct 13, 2023

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Oct 13, 2023

These tests are affected by the fix for showing the synthetic source, #98808. This can trigger an assert in older versions as the mapping they produce (without synthetic source) doesn't match the one they may get from the master, if the latter is in version 8.10+.

Fixes #100562

@kkrik-es kkrik-es added >test-mute Use for PR that only mute tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :StorageEngine/TSDB You know, for Metrics labels Oct 13, 2023
@kkrik-es kkrik-es self-assigned this Oct 13, 2023
@kkrik-es kkrik-es requested a review from martijnvg October 13, 2023 08:27
@kkrik-es kkrik-es changed the title Mute all tsdb tests in mixedClusterTests [TEST] Mute all tsdb tests in mixedClusterTests Oct 13, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@kkrik-es kkrik-es changed the title [TEST] Mute all tsdb tests in mixedClusterTests [TEST] Mute all tsdb tests in mixedClusterTests, for versions 8.7 - 8.10 Oct 13, 2023
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkrik-es kkrik-es added v8.10.5 auto-backport Automatically create backport pull requests when merged and removed v8.10.4 labels Oct 13, 2023
@kkrik-es kkrik-es merged commit ff6ef15 into elastic:main Oct 13, 2023
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.11
8.10 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 100805

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Oct 13, 2023
….10 (elastic#100805)

* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests elastic#2

* Don't print synthetic source in mapping for bwc tests elastic#2

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (elastic#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Oct 13, 2023
….10 (elastic#100805)

* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests elastic#2

* Don't print synthetic source in mapping for bwc tests elastic#2

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (elastic#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2023
….10 (#100805) (#100814)

* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests #2

* Don't print synthetic source in mapping for bwc tests #2

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2023
…8.7 - 8.10 (#100805) (#100815)

* [TEST] Mute all tsdb tests in mixedClusterTests, for versions 8.7 - 8.10 (#100805)

* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests #2

* Don't print synthetic source in mapping for bwc tests #2

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute

* Fix skip for position fields
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2023
…rce (#100827)

* [TEST] Mute all tsdb tests in mixedClusterTests, for versions 8.7 - 8.10 (#100805)

* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests #2

* Don't print synthetic source in mapping for bwc tests #2

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute

* Fix skip for position fields

* Restore version skip for synthetic source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-mute Use for PR that only mute tests v8.10.5 v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterClientYamlTestSuiteIT classMethod failing
3 participants