-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add require_data_stream
feature
#101872
Add require_data_stream
feature
#101872
Conversation
Hi @eyalkoren, I've created a changelog YAML for you. |
We'll switch to setting require_data_stream when it's available: elastic/elasticsearch#101872
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good general direction to me. I think we should check whether writing to an alias that points to a data stream will still work with the require_data_stream
flag (and potentially whether it should or should not.) I left a few minor comments since this is still a draft PR
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/update/UpdateRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/Metadata.java
Outdated
Show resolved
Hide resolved
require_data_stream
featurerequire_data_stream
feature
Pinging @elastic/es-data-management (Team:Data Management) |
Alright, I've pulled out the update support, and made this flag mean "if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
@elasticmachine update branch |
🎉 thank you @dakrone and @eyalkoren! |
Hello @dakrone and @eyalkoren Does this change have any impact when using Logstash elasticsearch output to index data on data streams, but on data streams that have a custom naming pattern? We are planning the upgrade to 8.13 and checking the release notes, we have Logstash writing to a custom data stream and since logstash does not support custom data stream names, we use Our logstash outputs are like this:
Not sure if this change here will break this. |
@leandrojmp this is an opt-in feature, so it will have no effect on your use case. You would need to reconfigure Logstash to pass |
Closes #97032
Adding the ability to set
require_data_stream
parameter (boolean) on several APIs.For document indexing and update, this flag affects also auto creation of underlying index - if set to
true
, an index will be created only if a matching index template is found and it contains a data stream template.