Add org.opensaml.security to X-Pack Security module-info

[droberts195]

My IntelliJ was refusing to compile SamlObjectHandler.java unless this extra line was added to module-info.java.

This doesn't currently affect official builds, nor anyone else's IntelliJ builds it would seem. However, I thought that since eventually some other change will make this necessary it doesn't hurt to add it now, and might save others time.

[elasticsearchmachine]

Pinging @elastic/es-security (Team:Security)

[droberts195]

This was the error I was getting:

The specific lines that were red in the IDE were these ones:

elasticsearch/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlObjectHandler.java

Lines 27 to 28 in b7eafce

	import org.opensaml.security.credential.Credential;
	import org.opensaml.security.x509.X509Credential;

[ChrisHegarty]

How things are setup here has changed fairly recently; use to be a shadow jar, now a transformed artifact, from #98199.

The relevant imports in SamlObjectHandler are :

import org.opensaml.security.credential.Credential;
import org.opensaml.security.x509.X509Credential;

The packages containing these classes come from "org.opensaml:opensaml-security-api", which is transformed in the build, see x-pack/libs/es-opensaml-security-api. The dependency from x-pack/security is on this transformed artifect. The transformed artifect has an Automatic-Module-Name: org.opensaml.security. This all seems ok.

The requires org.opensaml.security (as proposed in this PR) makes sense. But with it now my IDEA ( version 2023.2.1 ) complains:

IDEA is having problems with this transformed artifact, or that the dependency is from a shadow configuration:

  api project(path: ':x-pack:libs:es-opensaml-security-api', configuration: 'shadow')

[albertzaharovits]

IDEA is having problems with this transformed artifact, or that the dependency is from a shadow configuration:

I think that's the main problem and the module issue is just a symptom. I use the latest IntelliJ 2023.2.5.

I can see the same missing imports in the SamlFactory class from the x-pack.plugin.identity-provider project, which doesn't use modules (the imports are from the shadowed jar).
I checked and we already use the latest version of the shadow-jar plugin 8.1.1 (

elasticsearch/gradle/build.versions.toml

Line 40 in 8e9a88b

shadow-plugin = "com.github.johnrengelman:shadow:8.1.1"

https://imperceptiblethoughts.com/shadow/getting-started/).

[albertzaharovits]

I think I erroneously removed the module require statement in https://github.com/elastic/elasticsearch/pull/101904/files#r1394808215 (because my IntelliJ version was already not recognizing the shadowed jar deps).

[albertzaharovits]

I think we should merge this PR, and deal with the unrecognized shadow deps separately.

[arteam]

LGTM