Allow mismatched sort-by field types if there are no docs to sort #102779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
mayya-sharipova
approved these changes
Nov 30, 2023
|
@elasticmachine update branch |
benwtrent
added
the
auto-merge-without-approval
|
jenkins retest this please. |
|
run elasticsearch-ci |
|
@elasticmachine update branch |
benwtrent
deleted the
feature/allow-mismatched-sort-on-empty-result-fields
branch
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 30, 2023
…astic#102779) When searching multiple indices and a field only exists in ONE of the indices, we should allow sorting by that field, regardless of the "unmapped" type provided. closes: elastic#102723 (cherry picked from commit 43dc74b)
benwtrent
added a commit
that referenced
this pull request
Dec 1, 2023
…ort (#102779) (#102834) * Allow mismatched sort-by field types if there are no docs to sort (#102779) When searching multiple indices and a field only exists in ONE of the indices, we should allow sorting by that field, regardless of the "unmapped" type provided. closes: #102723 (cherry picked from commit 43dc74b) * fixing compile * fixing format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching multiple indices and a field only exists in ONE of the indices, we should allow sorting by that field, regardless of the "unmapped" type provided.
closes: #102723