Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix numbering in restore-snapshot.asciidoc #103769

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

fbaligand
Copy link
Contributor

Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.11.4 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 30, 2023
@iverase iverase added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Jan 2, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jan 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@abdonpijpelink abdonpijpelink self-assigned this Jan 3, 2024
@abdonpijpelink
Copy link
Contributor

@elasticsearchmachine test this please

fbaligand and others added 2 commits January 3, 2024 11:29
Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @fbaligand !

I've pushed a small change that keeps the restore-create-file-realm-user ID (it's used to link to this bullet elsewhere), fixes some asciidoc complex list quirks, and rebases the PR onto the main branch (so your change will also appear in future versions of the documentation).

@abdonpijpelink
Copy link
Contributor

@elasticsearchmachine test this please

@abdonpijpelink abdonpijpelink merged commit 4c87a7f into elastic:main Jan 3, 2024
5 checks passed
abdonpijpelink added a commit to abdonpijpelink/elasticsearch that referenced this pull request Jan 3, 2024
* docs: fix numbering in restore-snapshot.asciidoc

Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"

* Keep ID, fix list rendering

---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.12
8.11

abdonpijpelink added a commit to abdonpijpelink/elasticsearch that referenced this pull request Jan 3, 2024
* docs: fix numbering in restore-snapshot.asciidoc

Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"

* Keep ID, fix list rendering

---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Jan 3, 2024
* docs: fix numbering in restore-snapshot.asciidoc

Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"

* Keep ID, fix list rendering

---------

Co-authored-by: Fabien Baligand <fbaligand@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Jan 3, 2024
* docs: fix numbering in restore-snapshot.asciidoc

Fix numbering in "Restore an entire cluster" section.
Remove "3." for "Universal Profiling" and add "3." just before "If you use Elasticsearch security features"

* Keep ID, fix list rendering

---------

Co-authored-by: Fabien Baligand <fbaligand@gmail.com>
@fbaligand
Copy link
Contributor Author

Hi @abdonpijpelink,

Thanks for the fix on my fix ;)
And thanks for the merge!

@fbaligand fbaligand deleted the patch-3 branch January 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.11.4 v8.12.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants