Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify threading in SubscribableListener #106532

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Clarify threading in SubscribableListener #106532

merged 1 commit into from
Mar 20, 2024

Conversation

DaveCTurner
Copy link
Contributor

The docs about threading here are a little opaque to consumers, who
typically just want to ensure that the listener is completed on a
particular threadpool. This commit adds clearer docs about achieving
that goal.

@DaveCTurner
Clarify threading in SubscribableListener
1782a5e 
The docs about threading here are a little opaque to consumers, who
typically just want to ensure that the listener is completed on a
particular threadpool. This commit adds clearer docs about achieving
that goal.
@DaveCTurner DaveCTurner added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.14.0 labels Mar 20, 2024
@DaveCTurner DaveCTurner requested a review from droberts195 March 20, 2024 09:53
@DaveCTurner DaveCTurner mentioned this pull request Mar 20, 2024
Merged
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Mar 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

droberts195
droberts195 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for making the instructions more idiot-proof.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 20, 2024
@elasticsearchmachine elasticsearchmachine merged commit 504ef7c into elastic:main Mar 20, 2024
14 checks passed
@DaveCTurner DaveCTurner deleted the 2024/03/20/SubscribableListener-threading-clarification branch March 20, 2024 10:56
This was referenced Mar 21, 2024
Closed
Merged
Merged
@DaveCTurner DaveCTurner restored the 2024/03/20/SubscribableListener-threading-clarification branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @droberts195