Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support synthetic source for scaled_float and unsigned_long when ignore_malformed is used #109506

Merged

Conversation

lkts
Copy link
Contributor

@lkts lkts commented Jun 7, 2024

Contributes to #106483.

@lkts lkts added >feature :StorageEngine/Mapping The storage related side of mappings labels Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Hi @lkts, I've created a changelog YAML for you.

@lkts lkts marked this pull request as ready for review June 10, 2024 17:25
@lkts lkts requested review from martijnvg and kkrik-es June 10, 2024 17:25
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

summary: Support synthetic source for `scaled_float` and `unsigned_long` when `ignore_malformed`
is used
area: Mapping
type: feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe label as an enhancement?

@lkts
Copy link
Contributor Author

lkts commented Jun 12, 2024

@elasticmachine update branch

@lkts lkts merged commit c847235 into elastic:main Jun 12, 2024
15 checks passed
@lkts lkts deleted the feature/scaled_float_synthetic_source_ignore_malformed branch June 12, 2024 18:05
@felixbarny felixbarny mentioned this pull request Aug 6, 2024
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants