Refactor InferenceProcessorInfoExtractor to avoid ConfigurationUtils #115425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, read the maps non-destructively throughout this file.
joegallo
added
>refactoring
:ml
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Oct 23, 2024
💚 Backport successful
|
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigurationUtilsare a bit special-purpose -- they read from a mutable config map and they remove keys that have been read. There's other code in the rest of the ingest layer that makes sure that config maps have been exhausted after a processor has been constructed, which makes it part of a mechanism that makes sure that every key in the map is something that we recognize.Anyway, the uses here in
InferenceProcessorInfoExtractorare all 'just' checking the values, but they don't actually need to rely removing the values, so I've rewritten things slightly to avoid the use ofConfigurationUtilsaltogether.On its own, this PR doesn't have much to it -- the key thing that's not necessarily obvious from the code is that as a consequence of this PR the
InferenceProcessorInfoExtractorwill no longer rely on the processor config maps returned fromPipelineConfigurationeven being mutable at all, which a future PR is going to make be the case.