Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] ESQL: Allow duplicate warnings in some tests (#116199) #116367

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Nov 6, 2024

Backports the following commits to 8.x:

This fixes a test, actually in serverless Elasticsearch, that gets
duplicate warnings. We'd like not to emit these duplicate warnings, but
at this point it isn't worth it. So, for now, in some tests we allow
duplicate warnings. In most of our tests we do not allow duplicate
warnings so that we don't make *more* duplicate warnings without
thinking about it.
@nik9000 nik9000 added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 6, 2024
@elasticsearchmachine elasticsearchmachine merged commit 7bed305 into elastic:8.x Nov 6, 2024
15 checks passed
@nik9000 nik9000 deleted the backport/8.x/pr-116199 branch November 6, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants