[ML] Fix deberta tokenizer bug caused by bug in normalizer #117189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fesets to be negative
maxhniebergall
added
>bug
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
kderusso
reviewed
Nov 20, 2024
| @@ -194,7 +194,7 @@ Reader normalize(CharSequence str) { | |||
| if (charDelta < 0) { | |||
| // normalised form is shorter | |||
| int lastDiff = getLastCumulativeDiff(); | |||
| addOffCorrectMap(normalizedCharPos, lastDiff + charDelta); | |||
| addOffCorrectMap(normalizedCharPos, lastDiff - charDelta); | |||
There was a problem hiding this comment.
Subtle, nice find! Can we add any tests here as well?
There was a problem hiding this comment.
Good idea. I added a test which I confirmed fails prior to this fix, and works with this fix.
This was referenced Nov 21, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 21, 2024
…17189) * Fix deberta tokenizer bug caused by bug in normalizer which caused offesets to be negative * Update docs/changelog/117189.yaml
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 21, 2024
…17189) * Fix deberta tokenizer bug caused by bug in normalizer which caused offesets to be negative * Update docs/changelog/117189.yaml
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 21, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 21, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which caused offsets to be negative, and caused exceptions for some very rare input combinations.