Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse PutPipelineRequest#source earlier #117775

Closed
wants to merge 1 commit into from
Closed

Parse PutPipelineRequest#source earlier #117775

wants to merge 1 commit into from

Conversation

DaveCTurner
Copy link
Contributor

We don't need to pass around the REST request body verbatim when
processing a put-pipeline request, parsing it repeatedly as it's needed.
Instead we can parse the body once when starting to process the request
on the master, and pass the parsed Map around instead.

Relates #117038

@DaveCTurner
Parse PutPipelineRequest#source earlier
2c93bee 
We don't need to pass around the REST request body verbatim when
processing a put-pipeline request, parsing it repeatedly as it's needed.
Instead we can parse the body once when starting to process the request
on the master, and pass the parsed `Map` around instead.

Relates elastic#117038
@DaveCTurner DaveCTurner added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v9.0.0 labels Nov 29, 2024
@DaveCTurner DaveCTurner requested a review from joegallo November 29, 2024 15:02
@DaveCTurner DaveCTurner requested a review from a team as a code owner November 29, 2024 15:02
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Nov 29, 2024
@DaveCTurner
Copy link
Contributor Author

😢 everything in org.elasticsearch.ingest.ConfigurationUtils actually mutates the map, removing entries as it processes them, so the repeated parsing to Map<String,Object> is kind of necessary. Ugh. I don't think I want to work through the consequences of that, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegallo joegallo Awaiting requested review from joegallo

Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue Team:Data Management Meta label for data/management team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveCTurner @elasticsearchmachine