Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] add documentation for kuromoji_completion filter #117808

Merged
merged 1 commit into from
Dec 7, 2024
Merged

[DOC] add documentation for kuromoji_completion filter #117808

merged 1 commit into from
Dec 7, 2024

Conversation

pakio
Copy link
Contributor

@pakio pakio commented Dec 1, 2024

Closes #117807

This PR adds documentation for kuromoji_completion filter.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 1, 2024
@PeteGillinElastic PeteGillinElastic mentioned this pull request Dec 5, 2024
Closed
@PeteGillinElastic PeteGillinElastic added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP and removed needs:triage Requires assignment of a team area label labels Dec 5, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Dec 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@PeteGillinElastic PeteGillinElastic added :Search Relevance/Analysis How text is split into tokens and removed :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team labels Dec 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 5, 2024
@PeteGillinElastic
Copy link
Member

(Sorry, fat-fingered the wrong team at first, this should be correct.)

@john-wagster john-wagster self-assigned this Dec 6, 2024
@john-wagster john-wagster added the >docs General docs changes label Dec 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@john-wagster john-wagster added auto-backport Automatically create backport pull requests when merged v8.17.1 v8.18.0 labels Dec 6, 2024
@john-wagster
Copy link
Contributor

hi! @pakio I'll be helping you get this PR through. Really appreciate the contribution. Reviewing the changes now. If I find anything we need to iterate on I'll get back to you.

Have you had a chance to sign the contributors agreement: https://www.elastic.co/contributor-agreement

@john-wagster
Copy link
Contributor

@elasticmachine please test this

@john-wagster
Copy link
Contributor

@elasticmachine test this please

john-wagster
john-wagster approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc updates LGTM thanks again!

@pakio
Copy link
Contributor Author

pakio commented Dec 7, 2024

Hello @john-wagster, thanks for your review! I contributed to other elastic repository and I remember I've signed the agreement at that time.
I signed it again just in case so please confirm and let me know if there's anything else I need to check.

@john-wagster john-wagster merged commit 05eee61 into elastic:main Dec 7, 2024
7 checks passed
@john-wagster
Copy link
Contributor

looks good; merged! @pakio I'll make sure it's backported appropriately as well.

This was referenced Dec 7, 2024
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.17
✅ 8.x

john-wagster pushed a commit to john-wagster/elasticsearch that referenced this pull request Dec 7, 2024
@pakio @john-wagster
add documentation for kuromoji_completion (elastic#117808)
2496d51
john-wagster pushed a commit to john-wagster/elasticsearch that referenced this pull request Dec 7, 2024
@pakio @john-wagster
add documentation for kuromoji_completion (elastic#117808)
82459d8
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2024
@john-wagster @pakio
add documentation for kuromoji_completion (#117808) (#118199)
c90bf0d 
Co-authored-by: Kazuma Arimura <k.arimura96@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2024
@john-wagster @pakio
add documentation for kuromoji_completion (#117808) (#118200)
a0c27ab 
Co-authored-by: Kazuma Arimura <k.arimura96@gmail.com>
@pakio pakio deleted the doc-kuromoji-completion-filter branch December 7, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-wagster john-wagster john-wagster approved these changes

Assignees

@john-wagster john-wagster

Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Analysis How text is split into tokens Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing docs for the kuromoji_completion filter
4 participants
@pakio @elasticsearchmachine @PeteGillinElastic @john-wagster